| Message ID | 20250325-wip-obbardc-qcom-t14s-oled-panel-v2-2-e9bc7c9d30cc@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for OLED panel used on Snapdragon Lenovo T14s Gen6 | expand |
On 25/03/2025 19:21, Christopher Obbard wrote: > The eDP panel has an HPD GPIO. Describe it in the devicetree. > > Unfortunately I cannot test this on the non-OLED model since I > only have access to the model with OLED (which also uses the > HPD GPIO). > > I believe this could be split into two patches; one adding the > pinctrl node and one adding the hpd gpio to the T14s devicetree. > But I will wait for your comments on this ;-). There's nothing wrong with defining a pin when you also use it but emoji's in a commit log are surely verboten ! > > Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org> > --- > arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi > index 962fb050c55c4fd33f480a21a8c47a484d0c82b8..46c73f5c039ed982b553636cf8c4237a20ba7687 100644 > --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi > @@ -980,8 +980,12 @@ &mdss_dp3 { > aux-bus { > panel: panel { > compatible = "edp-panel"; > + hpd-gpios = <&tlmm 119 GPIO_ACTIVE_HIGH>; > power-supply = <&vreg_edp_3p3>; > > + pinctrl-0 = <&edp_hpd_n_default>; > + pinctrl-names = "default"; > + > port { > edp_panel_in: endpoint { > remote-endpoint = <&mdss_dp3_out>; > @@ -1286,6 +1290,13 @@ hall_int_n_default: hall-int-n-state { > bias-disable; > }; > > + edp_hpd_n_default: edp-hpd-n-state { > + pins = "gpio119"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; > + }; > + > pcie4_default: pcie4-default-state { > clkreq-n-pins { > pins = "gpio147"; > > -- > 2.49.0 > > This definition looks consistent with the schematic to me. Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On 25-03-25 19:21:27, Christopher Obbard wrote: > The eDP panel has an HPD GPIO. Describe it in the devicetree. > > Unfortunately I cannot test this on the non-OLED model since I > only have access to the model with OLED (which also uses the > HPD GPIO). > > I believe this could be split into two patches; one adding the > pinctrl node and one adding the hpd gpio to the T14s devicetree. > But I will wait for your comments on this ;-). You should definitely drop these two paragraphs entirely from the commit message. Maybe add them to the cover letter.
Hi Abel, On Thu, 27 Mar 2025 at 07:51, Abel Vesa <abel.vesa@linaro.org> wrote: > > On 25-03-25 19:21:27, Christopher Obbard wrote: > > The eDP panel has an HPD GPIO. Describe it in the devicetree. > > > > Unfortunately I cannot test this on the non-OLED model since I > > only have access to the model with OLED (which also uses the > > HPD GPIO). > > > > I believe this could be split into two patches; one adding the > > pinctrl node and one adding the hpd gpio to the T14s devicetree. > > But I will wait for your comments on this ;-). > > You should definitely drop these two paragraphs entirely from the commit > message. Maybe add them to the cover letter. Of course; I will do so in v3. But hey, it made you both reply, so in a way my comment did work ;-). Cheers! Chris
diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi index 962fb050c55c4fd33f480a21a8c47a484d0c82b8..46c73f5c039ed982b553636cf8c4237a20ba7687 100644 --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi @@ -980,8 +980,12 @@ &mdss_dp3 { aux-bus { panel: panel { compatible = "edp-panel"; + hpd-gpios = <&tlmm 119 GPIO_ACTIVE_HIGH>; power-supply = <&vreg_edp_3p3>; + pinctrl-0 = <&edp_hpd_n_default>; + pinctrl-names = "default"; + port { edp_panel_in: endpoint { remote-endpoint = <&mdss_dp3_out>; @@ -1286,6 +1290,13 @@ hall_int_n_default: hall-int-n-state { bias-disable; }; + edp_hpd_n_default: edp-hpd-n-state { + pins = "gpio119"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; + pcie4_default: pcie4-default-state { clkreq-n-pins { pins = "gpio147";
The eDP panel has an HPD GPIO. Describe it in the devicetree. Unfortunately I cannot test this on the non-OLED model since I only have access to the model with OLED (which also uses the HPD GPIO). I believe this could be split into two patches; one adding the pinctrl node and one adding the hpd gpio to the T14s devicetree. But I will wait for your comments on this ;-). Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org> --- arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)