diff mbox series

[v2,01/12] dt-bindings: soc: qcom,rpmh-rsc: Limit power-domains requirement

Message ID 20250327-topic-more_dt_bindings_fixes-v2-1-b763d958545f@oss.qualcomm.com (mailing list archive)
State New
Headers show
Series More more dt-bindings fixes for arm64/qcom | expand

Commit Message

Konrad Dybcio March 27, 2025, 1:47 a.m. UTC 
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Certain platforms (such as Chrome SDM845 and SC7180 with a TF-A running
as secure firmware) do not have a OSI-mode capable PSCI implementation.

That in turn means the PSCI-associated power domain which represents the
system's power state can't provide enough feedback to the RSC device.

Don't require power-domains on platforms where this may be the case.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 .../bindings/soc/qcom/qcom,rpmh-rsc.yaml           | 24 ++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski March 27, 2025, 8:18 a.m. UTC | #1 
On Thu, Mar 27, 2025 at 02:47:03AM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Certain platforms (such as Chrome SDM845 and SC7180 with a TF-A running
> as secure firmware) do not have a OSI-mode capable PSCI implementation.
> 
> That in turn means the PSCI-associated power domain which represents the
> system's power state can't provide enough feedback to the RSC device.
> 
> Don't require power-domains on platforms where this may be the case.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  .../bindings/soc/qcom/qcom,rpmh-rsc.yaml           | 24 ++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
index af632d0e0355c56748ecac24f528dc2eec7d1193..036562eb5140c78c10d845fd6efe42470b41895c 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,rpmh-rsc.yaml
@@ -44,7 +44,13 @@  description: |
 
 properties:
   compatible:
-    const: qcom,rpmh-rsc
+    oneOf:
+      - items:
+          - enum:
+              - qcom,sc7180-rpmh-apps-rsc
+              - qcom,sdm845-rpmh-apps-rsc
+          - const: qcom,rpmh-rsc
+      - const: qcom,rpmh-rsc
 
   interrupts:
     minItems: 1
@@ -124,7 +130,21 @@  required:
   - qcom,tcs-offset
   - reg
   - reg-names
-  - power-domains
+
+allOf:
+  # Some platforms may lack a OSI-mode PSCI implementation, which implies the
+  # system power domain can't provide feedback about entering power collapse
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - qcom,sc7180-rpmh-apps-rsc
+                - qcom,sdm845-rpmh-apps-rsc
+    then:
+      required:
+        - power-domains
 
 additionalProperties: false