| Message ID | 20250327-topic-more_dt_bindings_fixes-v2-11-b763d958545f@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | More more dt-bindings fixes for arm64/qcom | expand |
On Thu, Mar 27, 2025 at 02:47:13AM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > Because SA8775P comes with two disjoint CPU clusters, we have to follow > a similar topology description like the one in sm8750.dtsi, so: > > system_pd > cluster0_pd > cpu_pd0 > ... > cluster1_pd > cpu_pd4 > ... > > Do that & wire it up to APPS RSC to make the bindings checker happy. Should these two be separate commits? One being pure cosmetics and another one being a fix (probably with a Fixes tag). Anyway, Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >
On 3/27/25 3:00 PM, Dmitry Baryshkov wrote: > On Thu, Mar 27, 2025 at 02:47:13AM +0100, Konrad Dybcio wrote: >> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> >> >> Because SA8775P comes with two disjoint CPU clusters, we have to follow >> a similar topology description like the one in sm8750.dtsi, so: >> >> system_pd >> cluster0_pd >> cpu_pd0 >> ... >> cluster1_pd >> cpu_pd4 >> ... >> >> Do that & wire it up to APPS RSC to make the bindings checker happy. > > Should these two be separate commits? One being pure cosmetics and > another one being a fix (probably with a Fixes tag). potayto-potahto, both are needed to achieve a non-cosmetic bugfix Konrad
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index a904960359d731d2f0b6659a8ae99bff0e1bafb4..707c9dc3e748d9f24b38244bb468ec6db9c20efd 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -471,17 +471,17 @@ cpu_pd7: power-domain-cpu7 { cluster_0_pd: power-domain-cluster0 { #power-domain-cells = <0>; - power-domains = <&cluster_2_pd>; domain-idle-states = <&cluster_sleep_gold>; + power-domains = <&system_pd>; }; cluster_1_pd: power-domain-cluster1 { #power-domain-cells = <0>; - power-domains = <&cluster_2_pd>; domain-idle-states = <&cluster_sleep_gold>; + power-domains = <&system_pd>; }; - cluster_2_pd: power-domain-cluster2 { + system_pd: power-domain-system { #power-domain-cells = <0>; domain-idle-states = <&cluster_sleep_apss_rsc_pc>; }; @@ -4734,6 +4734,7 @@ apps_rsc: rsc@18200000 { <WAKE_TCS 3>, <CONTROL_TCS 0>; label = "apps_rsc"; + power-domains = <&system_pd>; apps_bcm_voter: bcm-voter { compatible = "qcom,bcm-voter";