From patchwork Wed Apr 2 11:45:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shao.mingyin@zte.com.cn X-Patchwork-Id: 14035834 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32334233153; Wed, 2 Apr 2025 11:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.216.63.40 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743594349; cv=none; b=P/RLzwjF1rvT93eLJa0GfUxfolA8UmQnj8GpgzzWYruMwAzzO91l8kXhg6oPdq0ULGbCQanR1Mw2IYW5ZcbaAXxWPYC5Q+RU/S3a9RHjM2mefaYSZG/GhK8TwOPCaZtFBS4yTitme2dffs3EIqqzt/ITm02XPmfOEcl9uCbcNu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743594349; c=relaxed/simple; bh=1FEXNb+3sgwnhrzy3P2QhZYbooTBMvl6WNcpdOtLPqc=; h=Date:Message-ID:In-Reply-To:References:Mime-Version:From:To:Cc: Subject:Content-Type; b=QsLc6x1Zxw9FmyUVRjyCLAQipLmh9EqOUpuB3K49i+fPNBJOtD+GvwFs77sIuJTzb7C4WFyh84pXrmPVKV/gkT+HtHyvyKjkH+lHXiHbgltC5K8IPLA1HuRFqtbgwM0ltuR6ZRzYWWxVMBtWu6DU/4kYUqMwiizF+TQrPybpq3U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn; spf=pass smtp.mailfrom=zte.com.cn; arc=none smtp.client-ip=63.216.63.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4ZSNNR0FSrz8QrkZ; Wed, 2 Apr 2025 19:45:43 +0800 (CST) Received: from xaxapp02.zte.com.cn ([10.88.97.241]) by mse-fl1.zte.com.cn with SMTP id 532Bjd3j070014; Wed, 2 Apr 2025 19:45:39 +0800 (+08) (envelope-from shao.mingyin@zte.com.cn) Received: from mapi (xaxapp04[null]) by mapi (Zmail) with MAPI id mid32; Wed, 2 Apr 2025 19:45:42 +0800 (CST) Date: Wed, 2 Apr 2025 19:45:42 +0800 (CST) X-Zmail-TransId: 2afb67ed2366ffffffffef7-237ea X-Mailer: Zmail v1.0 Message-ID: <20250402194542026OH8jAzuv0uq-J-D9AVPqJ@zte.com.cn> In-Reply-To: <20250402194100610qY6KQ4JPISk-4v214Qs36@zte.com.cn> References: 20250402194100610qY6KQ4JPISk-4v214Qs36@zte.com.cn Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 From: To: , Cc: , , , , , , , , , , , , , , , Subject: =?utf-8?q?=5BPATCH_linux-next_5/5=5D_phy=3A_rockchip=3A_phy-rockchi?= =?utf-8?q?p-typec=3A_Use=C2=A0dev=5Ferr=5Fprobe=28=29?= X-MAIL: mse-fl1.zte.com.cn 532Bjd3j070014 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 67ED2367.000/4ZSNNR0FSrz8QrkZ From: Zhang Enpei Replace the open-code with dev_err_probe() to simplify the code. Signed-off-by: Zhang Enpei Signed-off-by: Shao Mingyin Reviewed-by: Sebastian Reichel --- drivers/phy/rockchip/phy-rockchip-typec.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c index d9701b6106d5..94d1e6ead1a7 100644 --- a/drivers/phy/rockchip/phy-rockchip-typec.c +++ b/drivers/phy/rockchip/phy-rockchip-typec.c @@ -1151,11 +1151,9 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev) if (IS_ERR(tcphy->extcon)) { if (PTR_ERR(tcphy->extcon) == -ENODEV) { tcphy->extcon = NULL; - } else { - if (PTR_ERR(tcphy->extcon) != -EPROBE_DEFER) - dev_err(dev, "Invalid or missing extcon\n"); - return PTR_ERR(tcphy->extcon); - } + } else + return dev_err_probe(dev, PTR_ERR(tcphy->extcon), + "Invalid or missing extcon\n"); } pm_runtime_enable(dev);