| Message ID | 20250408145252.581060-2-juerg.haefliger@canonical.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | HP EliteBook Ultra G1q support | expand |
> Introduce a device tree for the HP EliteBook Ultra G1q 14" AI laptop. It > seems to be using the same baseboard as the HP OmniBook X 14 so just use > that for now. > > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../qcom/x1e80100-hp-elitebook-ultra-g1q.dts | 36 +++++++++++++++++++ > drivers/firmware/qcom/qcom_scm.c | 1 + > 3 files changed, 38 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 710879d94c00..3d98bb95e8b1 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -294,6 +294,7 @@ dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s-oled.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-vivobook-s15.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-dell-xps13-9345.dtb > +dtb-$(CONFIG_ARCH_QCOM) += x1e80100-hp-elitebook-ultra-g1q.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-hp-omnibook-x14.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-lenovo-yoga-slim7x.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus13.dtb > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts > new file mode 100644 > index 000000000000..9f3aac1a83fd > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts > @@ -0,0 +1,36 @@ > +// SPDX-License-Identifier: BSD-3-Clause > + > +/dts-v1/; > + > +#include "x1e80100-hp-omnibook-x14.dts" > + > +/ { > + model = "HP EliteBook Ultra G1q"; > + compatible = "hp,elitebook-ultra-g1q", "qcom,x1e80100"; > +}; > + > +&gpu { > + status = "okay"; status should not be needed as it is already set in the omnibook dts > + > + zap-shader { > + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qcdxkmsuc8380.mbn"; > + }; > +}; > + > +&remoteproc_adsp { > + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qcadsp8380.mbn", > + "qcom/x1e80100/hp/elitebook-ultra-g1q/adsp_dtbs.elf"; > + > + status = "okay"; same here > +}; > + > +&remoteproc_cdsp { > + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qccdsp8380.mbn", > + "qcom/x1e80100/hp/elitebook-ultra-g1q/cdsp_dtbs.elf"; > + > + status = "okay"; same here Kind regards, Maud > +}; > + > +&sound { > + model = "X1E80100-HP-ELITEBOOK-ULTRA-G1Q"; > +}; > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c > index fc4d67e4c4a6..e7262ad11509 100644 > --- a/drivers/firmware/qcom/qcom_scm.c > +++ b/drivers/firmware/qcom/qcom_scm.c > @@ -1987,6 +1987,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send); > static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = { > { .compatible = "asus,vivobook-s15" }, > { .compatible = "dell,xps13-9345" }, > + { .compatible = "hp,elitebook-ultra-g1q" }, > { .compatible = "hp,omnibook-x14" }, > { .compatible = "huawei,gaokun3" }, > { .compatible = "lenovo,flex-5g" }, > -- > 2.43.0
Ignore this message I reply to, I replied to the wrong patch accidentaly. Sorry all. Kind regards, Maud>> Introduce a device tree for the HP EliteBook Ultra G1q 14" AI laptop. It >> seems to be using the same baseboard as the HP OmniBook X 14 so just use >> that for now. >> >> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> .../qcom/x1e80100-hp-elitebook-ultra-g1q.dts | 36 +++++++++++++++++++ >> drivers/firmware/qcom/qcom_scm.c | 1 + >> 3 files changed, 38 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index 710879d94c00..3d98bb95e8b1 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -294,6 +294,7 @@ dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s-oled.dtb >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-vivobook-s15.dtb >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-dell-xps13-9345.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += x1e80100-hp-elitebook-ultra-g1q.dtb >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-hp-omnibook-x14.dtb >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-lenovo-yoga-slim7x.dtb >> dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus13.dtb >> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts >> new file mode 100644 >> index 000000000000..9f3aac1a83fd >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts >> @@ -0,0 +1,36 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> + >> +/dts-v1/; >> + >> +#include "x1e80100-hp-omnibook-x14.dts" >> + >> +/ { >> + model = "HP EliteBook Ultra G1q"; >> + compatible = "hp,elitebook-ultra-g1q", "qcom,x1e80100"; >> +}; >> + >> +&gpu { >> + status = "okay"; > > status should not be needed as it is already set in the omnibook dts > >> + >> + zap-shader { >> + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qcdxkmsuc8380.mbn"; >> + }; >> +}; >> + >> +&remoteproc_adsp { >> + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qcadsp8380.mbn", >> + "qcom/x1e80100/hp/elitebook-ultra-g1q/adsp_dtbs.elf"; >> + >> + status = "okay"; > > same here > >> +}; >> + >> +&remoteproc_cdsp { >> + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qccdsp8380.mbn", >> + "qcom/x1e80100/hp/elitebook-ultra-g1q/cdsp_dtbs.elf"; >> + >> + status = "okay"; > > same here > > Kind regards, > Maud > >> +}; >> + >> +&sound { >> + model = "X1E80100-HP-ELITEBOOK-ULTRA-G1Q"; >> +}; >> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c >> index fc4d67e4c4a6..e7262ad11509 100644 >> --- a/drivers/firmware/qcom/qcom_scm.c >> +++ b/drivers/firmware/qcom/qcom_scm.c >> @@ -1987,6 +1987,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send); >> static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = { >> { .compatible = "asus,vivobook-s15" }, >> { .compatible = "dell,xps13-9345" }, >> + { .compatible = "hp,elitebook-ultra-g1q" }, >> { .compatible = "hp,omnibook-x14" }, >> { .compatible = "huawei,gaokun3" }, >> { .compatible = "lenovo,flex-5g" }, >> -- >> 2.43.0
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts index 03bbebff4576..06a53b3e8cb9 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts @@ -166,9 +166,8 @@ linux,cma { }; }; - sound { + sound: sound { compatible = "qcom,x1e80100-sndcard"; - model = "X1E80100-HP-OMNIBOOK-X14"; audio-routing = "SpkrLeft IN", "WSA WSA_SPK1 OUT", "SpkrRight IN", "WSA WSA_SPK2 OUT", "IN1_HPHL", "HPHL_OUT", @@ -1555,3 +1554,7 @@ &usb_mp_qmpphy0 { status = "okay"; }; + +&sound { + model = "X1E80100-HP-OMNIBOOK-X14"; +};
Add a label to the sound node and pull out the model name to make it explicit and easier to override it from other nodes. Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> --- arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)