| Message ID | 20250408145252.581060-4-juerg.haefliger@canonical.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | HP EliteBook Ultra G1q support | expand |
Sorry I messed up and replied to the wrong patch somehow, this comment was meant for this patch. > Introduce a device tree for the HP EliteBook Ultra G1q 14" AI laptop. It > seems to be using the same baseboard as the HP OmniBook X 14 so just use > that for now. > > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../qcom/x1e80100-hp-elitebook-ultra-g1q.dts | 36 +++++++++++++++++++ > drivers/firmware/qcom/qcom_scm.c | 1 + > 3 files changed, 38 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 710879d94c00..3d98bb95e8b1 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -294,6 +294,7 @@ dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s-oled.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-vivobook-s15.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-dell-xps13-9345.dtb > +dtb-$(CONFIG_ARCH_QCOM) += x1e80100-hp-elitebook-ultra-g1q.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-hp-omnibook-x14.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-lenovo-yoga-slim7x.dtb > dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus13.dtb > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts > new file mode 100644 > index 000000000000..9f3aac1a83fd > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts > @@ -0,0 +1,36 @@ > +// SPDX-License-Identifier: BSD-3-Clause > + > +/dts-v1/; > + > +#include "x1e80100-hp-omnibook-x14.dts" > + > +/ { > + model = "HP EliteBook Ultra G1q"; > + compatible = "hp,elitebook-ultra-g1q", "qcom,x1e80100"; > +}; > + > +&gpu { > + status = "okay"; status should not be needed as it is already set in the omnibook dts > + > + zap-shader { > + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qcdxkmsuc8380.mbn"; > + }; > +}; > + > +&remoteproc_adsp { > + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qcadsp8380.mbn", > + "qcom/x1e80100/hp/elitebook-ultra-g1q/adsp_dtbs.elf"; > + > + status = "okay"; same here > +}; > + > +&remoteproc_cdsp { > + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qccdsp8380.mbn", > + "qcom/x1e80100/hp/elitebook-ultra-g1q/cdsp_dtbs.elf"; > + > + status = "okay"; same here Kind regards, Maud > +}; > + > +&sound { > + model = "X1E80100-HP-ELITEBOOK-ULTRA-G1Q"; > +}; > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c > index fc4d67e4c4a6..e7262ad11509 100644 > --- a/drivers/firmware/qcom/qcom_scm.c > +++ b/drivers/firmware/qcom/qcom_scm.c > @@ -1987,6 +1987,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send); > static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = { > { .compatible = "asus,vivobook-s15" }, > { .compatible = "dell,xps13-9345" }, > + { .compatible = "hp,elitebook-ultra-g1q" }, > { .compatible = "hp,omnibook-x14" }, > { .compatible = "huawei,gaokun3" }, > { .compatible = "lenovo,flex-5g" }, > -- > 2.43.0
On 4/10/25 7:34 AM, Maud Spierings wrote: > Sorry I messed up and replied to the wrong patch somehow, this comment was meant for this patch. > >> Introduce a device tree for the HP EliteBook Ultra G1q 14" AI laptop. It >> seems to be using the same baseboard as the HP OmniBook X 14 so just use >> that for now. https://lore.kernel.org/lkml/20230510183423.never.877-kees@kernel.org/ Konrad
On Thu, Apr 10, 2025 at 06:41:17PM +0200, Konrad Dybcio wrote: > On 4/10/25 7:34 AM, Maud Spierings wrote: > > Sorry I messed up and replied to the wrong patch somehow, this comment was meant for this patch. > > > >> Introduce a device tree for the HP EliteBook Ultra G1q 14" AI laptop. It > >> seems to be using the same baseboard as the HP OmniBook X 14 so just use > >> that for now. > > https://lore.kernel.org/lkml/20230510183423.never.877-kees@kernel.org/ It seems you missed Maud's inline comments: https://lore.kernel.org/lkml/AM7P189MB100977CCFD602396E8F01FCBE3B72@AM7P189MB1009.EURP189.PROD.OUTLOOK.COM/ Johan
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 710879d94c00..3d98bb95e8b1 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -294,6 +294,7 @@ dtb-$(CONFIG_ARCH_QCOM) += x1e78100-lenovo-thinkpad-t14s-oled.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-asus-vivobook-s15.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-crd.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-dell-xps13-9345.dtb +dtb-$(CONFIG_ARCH_QCOM) += x1e80100-hp-elitebook-ultra-g1q.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-hp-omnibook-x14.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-lenovo-yoga-slim7x.dtb dtb-$(CONFIG_ARCH_QCOM) += x1e80100-microsoft-romulus13.dtb diff --git a/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts b/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts new file mode 100644 index 000000000000..9f3aac1a83fd --- /dev/null +++ b/arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts @@ -0,0 +1,36 @@ +// SPDX-License-Identifier: BSD-3-Clause + +/dts-v1/; + +#include "x1e80100-hp-omnibook-x14.dts" + +/ { + model = "HP EliteBook Ultra G1q"; + compatible = "hp,elitebook-ultra-g1q", "qcom,x1e80100"; +}; + +&gpu { + status = "okay"; + + zap-shader { + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qcdxkmsuc8380.mbn"; + }; +}; + +&remoteproc_adsp { + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qcadsp8380.mbn", + "qcom/x1e80100/hp/elitebook-ultra-g1q/adsp_dtbs.elf"; + + status = "okay"; +}; + +&remoteproc_cdsp { + firmware-name = "qcom/x1e80100/hp/elitebook-ultra-g1q/qccdsp8380.mbn", + "qcom/x1e80100/hp/elitebook-ultra-g1q/cdsp_dtbs.elf"; + + status = "okay"; +}; + +&sound { + model = "X1E80100-HP-ELITEBOOK-ULTRA-G1Q"; +}; diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index fc4d67e4c4a6..e7262ad11509 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -1987,6 +1987,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send); static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = { { .compatible = "asus,vivobook-s15" }, { .compatible = "dell,xps13-9345" }, + { .compatible = "hp,elitebook-ultra-g1q" }, { .compatible = "hp,omnibook-x14" }, { .compatible = "huawei,gaokun3" }, { .compatible = "lenovo,flex-5g" },
Introduce a device tree for the HP EliteBook Ultra G1q 14" AI laptop. It seems to be using the same baseboard as the HP OmniBook X 14 so just use that for now. Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com> --- arch/arm64/boot/dts/qcom/Makefile | 1 + .../qcom/x1e80100-hp-elitebook-ultra-g1q.dts | 36 +++++++++++++++++++ drivers/firmware/qcom/qcom_scm.c | 1 + 3 files changed, 38 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-hp-elitebook-ultra-g1q.dts