From patchwork Fri May 22 13:15:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 6464271 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 68CE99F1C1 for ; Fri, 22 May 2015 13:15:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 973782047B for ; Fri, 22 May 2015 13:15:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8A7E20437 for ; Fri, 22 May 2015 13:15:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757586AbbEVNPd (ORCPT ); Fri, 22 May 2015 09:15:33 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:62389 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757363AbbEVNPa (ORCPT ); Fri, 22 May 2015 09:15:30 -0400 Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue003) with ESMTPSA (Nemesis) id 0M1kWE-1ZApVK3XUQ-00tmFu; Fri, 22 May 2015 15:15:21 +0200 From: Arnd Bergmann To: Srinivas Kandagatla Cc: Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Kenneth Westfield , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF Date: Fri, 22 May 2015 15:15:15 +0200 Message-ID: <2168878.0V0FR6oKgi@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <2534276.hIjFJK74Zh@wuerfel> References: <1432245125-8939-1-git-send-email-srinivas.kandagatla@linaro.org> <1432245161-8990-1-git-send-email-srinivas.kandagatla@linaro.org> <2534276.hIjFJK74Zh@wuerfel> MIME-Version: 1.0 X-Provags-ID: V03:K0:v2uTxL0q1NGGjB2MuL0AFi0mbvLoOuL9PHYW9q8FjLfrk2OJSN7 H4PuKMW+WD8gTXyhLcZz9YBLWYU1+P5ZDGJ1/ighLMDlXhrxji4ENm11Nc+IKW3SS2zDLBe IWaAfVWvEz9hWnRfpagZV11INWxvmRIry7g7hkZyEWCh9vItMc7ioulO3t5nACui13vNQ52 tIEPDgI9XgMga6geDY/ew== X-UI-Out-Filterresults: notjunk:1; Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Friday 22 May 2015 09:24:35 Arnd Bergmann wrote: > Could you instead make the drivers compile without OF being set? > > I see that patch 7 and 8 introduces another two options doing > > > +config SND_SOC_LPASS_APQ8016 > + tristate > + depends on SND_SOC_QCOM > + select SND_SOC_LPASS_CPU > + select SND_SOC_LPASS_PLATFORM > + > > +config SND_SOC_APQ8016_SBC > + tristate "SoC Audio support for APQ8016 SBC platforms" > + depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST > + select SND_SOC_LPASS_APQ8016 > + help > > so you get an obvious build failure here when SND_SOC_APQ8016_SBC > gets selected with COMPILE_TEST on a platform that does not support OF. > > Actually, the patch 9bae4880acee ("ASoC: qcom: move ipq806x specific bits out of lpass driver.") already broke things more after I fixed it up. Please fold in this bit too before you send it again, and try to test the changes you send: Arnd --- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index b30c2baa7501..08ebc9b8f915 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -20,7 +20,7 @@ config SND_SOC_LPASS_IPQ806X config SND_SOC_STORM tristate "ASoC I2S support for Storm boards" - depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST + depends on SND_SOC_QCOM && (ARCH_QCOM || COMPILE_TEST) select SND_SOC_LPASS_IPQ806X select SND_SOC_MAX98357A help