| Message ID | 251e00c8-40f4-1712-f732-1351361f667a@free.fr (mailing list archive) |
|---|---|
| State | Mainlined |
| Headers | show |
| Series | [v2] regulator: core: Log forbidden DRMS operation | expand |
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 59782a706ac4..64f91cf21846 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -930,8 +930,10 @@ static int drms_uA_update(struct regulator_dev *rdev) * first check to see if we can set modes at all, otherwise just * tell the consumer everything is OK. */ - if (!regulator_ops_is_valid(rdev, REGULATOR_CHANGE_DRMS)) + if (!regulator_ops_is_valid(rdev, REGULATOR_CHANGE_DRMS)) { + rdev_dbg(rdev, "DRMS operation not allowed\n"); return 0; + } if (!rdev->desc->ops->get_optimum_mode && !rdev->desc->ops->set_load)
When REGULATOR_CHANGE_DRMS is not set, drms_uA_update is a no-op. It used to print a debug message, which was dropped in commit 8a34e979f684 ("regulator: refactor valid_ops_mask checking code") Let's bring the debug message back, because it helps find missing regulator-allow-set-load properties. Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> --- drivers/regulator/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)