| Message ID | 31108a78-e158-5147-2f2f-cd300cb5d49b@free.fr (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | UFS on APQ8098/MSM8998 | expand |
On 2/4/2019 10:37 AM, Marc Gonzalez wrote: > The UFS host controller driver needs to set the load on 3 power rails > (l20, l26, s4) but the operation fails silently unless we specify the > regulator-allow-set-load property in the corresponding DT nodes. > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > --- Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> > arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > index 80075283847a..198885db775e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi > @@ -104,6 +104,7 @@ > vreg_s4a_1p8: s4 { > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > + regulator-allow-set-load; > }; > vreg_s5a_2p04: s5 { > regulator-min-microvolt = <1904000>; > @@ -188,6 +189,7 @@ > vreg_l20a_2p95: l20 { > regulator-min-microvolt = <2960000>; > regulator-max-microvolt = <2960000>; > + regulator-allow-set-load; > }; > vreg_l21a_2p95: l21 { > regulator-min-microvolt = <2960000>; > @@ -212,6 +214,7 @@ > vreg_l26a_1p2: l26 { > regulator-min-microvolt = <1200000>; > regulator-max-microvolt = <1200000>; > + regulator-allow-set-load; > }; > vreg_l28_3p0: l28 { > regulator-min-microvolt = <3008000>; >
diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi index 80075283847a..198885db775e 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi @@ -104,6 +104,7 @@ vreg_s4a_1p8: s4 { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-allow-set-load; }; vreg_s5a_2p04: s5 { regulator-min-microvolt = <1904000>; @@ -188,6 +189,7 @@ vreg_l20a_2p95: l20 { regulator-min-microvolt = <2960000>; regulator-max-microvolt = <2960000>; + regulator-allow-set-load; }; vreg_l21a_2p95: l21 { regulator-min-microvolt = <2960000>; @@ -212,6 +214,7 @@ vreg_l26a_1p2: l26 { regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; + regulator-allow-set-load; }; vreg_l28_3p0: l28 { regulator-min-microvolt = <3008000>;
The UFS host controller driver needs to set the load on 3 power rails (l20, l26, s4) but the operation fails silently unless we specify the regulator-allow-set-load property in the corresponding DT nodes. Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> --- arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 3 +++ 1 file changed, 3 insertions(+)