From patchwork Fri Nov 20 09:43:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7666191 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 834989F2EC for ; Fri, 20 Nov 2015 09:43:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A176B2045E for ; Fri, 20 Nov 2015 09:43:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABC7A203AD for ; Fri, 20 Nov 2015 09:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934857AbbKTJni (ORCPT ); Fri, 20 Nov 2015 04:43:38 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:64411 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934085AbbKTJng (ORCPT ); Fri, 20 Nov 2015 04:43:36 -0500 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0LbUhX-1af3F72vSF-00lC3l; Fri, 20 Nov 2015 10:43:03 +0100 From: Arnd Bergmann To: Andy Gross , linux-arm-msm@vger.kernel.org Cc: Kumar Gala , David Brown , linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , linux-arm-kernel@lists.infradead.org Subject: [PATCH] drivers/built-in.o: In function `qcom_smp2p_intr': Date: Fri, 20 Nov 2015 10:43 +0100 Message-ID: <47507465.yGmu2TCElj@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:L3h20ybYgxk2FpUbOun2BcqRnbtKp7PIZSK41ZDsY+8M+vpmPVJ 3orHEH7EdB/U/z78WTjNSB4FmL4BQ4/0pFOoeTksH2OmKnPMQy1INJ48/BtVNhcudQpD4cF glUUL1QXgulJyrrsq2RPY+QJ6mXU92Xlwtm82dnhl+3eF5hJB0sqFUUewlw7sWp6d71l8+J sOmTX8OHaDzbi0T9NaMlw== X-UI-Out-Filterresults: notjunk:1; V01:K0:bB2yoW7/rlI=:tsA3xf8jGoKGCuDkZReLU4 0nGEZjmNywF2oS6tN0x6/8CPIZ6hZ6cEFfGsYNpc1kAbA2qNFHkBSL08yA3w3wc0T/kO5ozjZ 4SBPB1w8y2RrtovY63OxBZM9TF89H04mqgpdU5tStQEGgfXvt8BXYu8grMnO5Qb3sDz479UuV ThEOz/yA/UVvPPjhSjY97VTiW96dMZkwYp3PUnfJFkk4Bluv4yvRMlokDSK2d6JfkKU7MqDya dxqTBXGZ6RiBpTCCIhbjFGKfly6Zvg/jMktDwWvHP4wKJfBLkxHjqYkLmX9fdGWeGQAZBvsCV 5WdZ7cNOgZ/jbvOuJvEM74qFqjUhG+2uELTUyKC1YS3snsSiKFvII7tFOpPffJQ9Bf0V+ZV5f WARe+d5HrymX8UQRI68N1MsFxGX9F0qjUszXgX+8fBY2jhxPx3eyyyCZndqeFcAH49pxoVy5k XNHMX4Thcld3nsFd1C2NAcOyOuUTQ0JW/i19w9WMECfsejqCW+RBNvYOv3bm4OtKChDtcVams oMZlvBh6X2ikbZxW7KYtO87GGmfADlA3OzvQiEXzQQ/HmB9InBeNGkdzkzfmcXA+q0su1MTYo wm7J8mfrkjgc4VoV9qaJ6+YSAI+6IDunfmeBr2WOo0XF14r4h+lzpLE+PHM0fSVHnTQ3Eae1t OplhalftL1H3dalKvL7fi8DCH77+Tjctt5mCvM9mvUMRU58YQ0hJ2mqYpUzNU8VI1iiJblKFM P0uVFHCO+LzJsRD4 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The newly added smp2p and smsm drivers cannot be loadable modules but depend on smem, which can be, and that causes a link error: :(.text+0xa6e68): undefined reference to `qcom_smem_get' drivers/built-in.o: In function `qcom_smp2p_probe': :(.text+0xa7320): undefined reference to `qcom_smem_alloc' :(.text+0xa736c): undefined reference to `qcom_smem_get' drivers/built-in.o: In function `qcom_smsm_probe': :(.text+0xa7b34): undefined reference to `qcom_smem_get' This marks all the drivers as 'tristate' to make the Kconfig dependency resolution work properly. Signed-off-by: Arnd Bergmann Fixes: dbb04bd7122f ("soc: qcom: smp2p: Qualcomm Shared Memory Point to Point") Fixes: d7387fc6add4 ("soc: qcom: smsm: Add driver for Qualcomm SMSM") --- This showed up on arm allmodconfig with linux-next today, please apply or fold into the original patches. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index b57be7ab50b6..57b7145358e7 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -54,7 +54,7 @@ config QCOM_SMEM_STATE bool config QCOM_SMP2P - bool "Qualcomm Shared Memory Point to Point support" + tristate "Qualcomm Shared Memory Point to Point support" depends on QCOM_SMEM select QCOM_SMEM_STATE help @@ -62,7 +62,7 @@ config QCOM_SMP2P protocol. config QCOM_SMSM - bool "Qualcomm Shared Memory State Machine" + tristate "Qualcomm Shared Memory State Machine" depends on QCOM_SMEM select QCOM_SMEM_STATE help