| Message ID | 5294153.vxTnuIq2gr@wuerfel (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On Thu, Oct 15, 2015 at 11:05:27PM +0200, Arnd Bergmann wrote: > On Wednesday 14 October 2015 17:10:27 Andy Gross wrote: > > Qualcomm ARM Based SoC Updates for 4.4 > > > > * Implement id_table driver matching in SMD > > * Avoid NULL pointer exception on remove of SMEM > > * Reorder SMEM/SMD configs > > * Make qcom_smem_get() return a pointer > > * Handle big endian CPUs correctly in SMEM > > * Represent SMD channel layout in structures > > * Use __iowrite32_copy() in SMD > > * Remove use of VLAIs in SMD > > * Handle big endian CPUs correctly in SMD/RPM > > * Handle big endian CPUs corretly in SMD > > * Reject sending SMD packets that are too large > > * Fix endianness issue in SCM __qcom_scm_is_call_available > > * Add missing prototype for qcom_scm_is_available() > > * Correct SMEM items for upper channels > > * Use architecture level to build SCM correctly > > * Delete unneeded of_node_put in SMD > > * Correct active/slep state flagging in SMD/RPM > > * Move RPM message ram out of SMEM DT node > > > > Pulled into next/drivers, but please try to make the changelogs more readable > in the future. No point listing each small patch here, instead say what you've > done overall and what the major things are. Right now, the merge commit > just duplicates the information like this: Fair enough. I'll condense it next time. Thanks for the hwspinlock fix on top.
On 10/15/2015 02:05 PM, Arnd Bergmann wrote: > > This also seemed like the right place > to add a bugfix that I had in my queue: > > commit 73ebb85444b0472d90bb70a1a9e6b5df3f92c14c > Author: Arnd Bergmann <arnd@arndb.de> > Date: Tue Oct 13 17:05:39 2015 +0200 > > soc: qcom/smem: add HWSPINLOCK dependency > > This fixes a build error when smem is enabled without hwspinlock: > > drivers/built-in.o: In function `qcom_smem_alloc': > rockchip-efuse.c:(.text+0x7a3e4): undefined reference to `__hwspin_lock_timeout' > rockchip-efuse.c:(.text+0x7a568): undefined reference to `__hwspin_unlock' > drivers/built-in.o: In function `qcom_smem_remove': > rockchip-efuse.c:(.text+0x7a5cc): undefined reference to `hwspin_lock_free' > drivers/built-in.o: In function `qcom_smem_probe': > rockchip-efuse.c:(.text+0x7a960): undefined reference to `hwspin_lock_request_specific' > rockchip-efuse.c:(.text+0x7a988): undefined reference to `of_hwspin_lock_get_id' > drivers/built-in.o: In function `qcom_smem_get': > rockchip-efuse.c:(.text+0x7aa24): undefined reference to `__hwspin_lock_timeout' > rockchip-efuse.c:(.text+0x7aafc): undefined reference to `__hwspin_unlock' > Can you share your .config? It looks like there are stubs for these, so I'm lost how we got undefined references.
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index 3e4d2133c3d2..eec76141d9b9 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -22,6 +22,7 @@ config QCOM_PM config QCOM_SMEM tristate "Qualcomm Shared Memory Manager (SMEM)" depends on ARCH_QCOM + depends on HWSPINLOCK help Say y here to enable support for the Qualcomm Shared Memory Manager. The driver provides an interface to items in a heap shared among all