diff mbox series

[v5,6/6] dt-bindings: clock: Introduce pdc bindings for SDX65

Message ID 538438f41153587043741747db5218e9f575c0f5.1637302009.git.quic_vamslank@quicinc.com (mailing list archive)
State Not Applicable
Headers show
Series Add Pdc, GCC and RPMh clock support for SDX65 | expand

Commit Message

Vamsi Krishna Lanka Nov. 19, 2021, 6:11 a.m. UTC
From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>

Add compatible for SDX65 pdc.

Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Vinod Koul <vkoul@kernel.org>
---
 .../devicetree/bindings/interrupt-controller/qcom,pdc.txt        | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjorn Andersson Nov. 27, 2021, 12:06 a.m. UTC | #1
On Thu 18 Nov 22:11 PST 2021, quic_vamslank@quicinc.com wrote:

> From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> 
> Add compatible for SDX65 pdc.
> 
> Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>

Sorry for not spotting this before, but as you can tell from the path of
the file you're changing, this has nothing to do with "clocks".

git log on qcom,pdc.txt shows that $subject should be:

  dt-bindings: qcom,pdc: Add compatible for SDX65

Also, as this is unrelated to clocks, Stephen is not going to merge this
patch. You will have to repost it, with Marc Zyngier as recipient to get
it merged; per get_maintainer.


I think it's fine to keep the reviews and acks while adjusting $subject
and reposting this patch  - separate from the other 5 patches.

Thanks,
Bjorn

> ---
>  .../devicetree/bindings/interrupt-controller/qcom,pdc.txt        | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> index 98d89e53013d..ce631d853db4 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> @@ -23,6 +23,7 @@ Properties:
>  		    - "qcom,sdm845-pdc": For SDM845
>  		    - "qcom,sdm8250-pdc": For SM8250
>  		    - "qcom,sdm8350-pdc": For SM8350
> +		    - "qcom,sdx65-pdc": For SDX65
>  
>  - reg:
>  	Usage: required
> -- 
> 2.33.1
>
Vamsi Krishna Lanka Dec. 1, 2021, 10:26 p.m. UTC | #2
On Fri, Nov 26, 2021 at 04:06:16PM -0800, Bjorn Andersson wrote:
> On Thu 18 Nov 22:11 PST 2021, quic_vamslank@quicinc.com wrote:
> 
> > From: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> > 
> > Add compatible for SDX65 pdc.
> > 
> > Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Acked-by: Rob Herring <robh@kernel.org>
> > Reviewed-by: Vinod Koul <vkoul@kernel.org>
> 
> Sorry for not spotting this before, but as you can tell from the path of
> the file you're changing, this has nothing to do with "clocks".
> 
> git log on qcom,pdc.txt shows that $subject should be:
> 
>   dt-bindings: qcom,pdc: Add compatible for SDX65
> 
> Also, as this is unrelated to clocks, Stephen is not going to merge this
> patch. You will have to repost it, with Marc Zyngier as recipient to get
> it merged; per get_maintainer.
> 
> 
> I think it's fine to keep the reviews and acks while adjusting $subject
> and reposting this patch  - separate from the other 5 patches.

Thank you for the review. Will repost this as a new patch.

Thanks,
Vamsi
> 
> Thanks,
> Bjorn
> 
> > ---
> >  .../devicetree/bindings/interrupt-controller/qcom,pdc.txt        | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> > index 98d89e53013d..ce631d853db4 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
> > @@ -23,6 +23,7 @@ Properties:
> >  		    - "qcom,sdm845-pdc": For SDM845
> >  		    - "qcom,sdm8250-pdc": For SM8250
> >  		    - "qcom,sdm8350-pdc": For SM8350
> > +		    - "qcom,sdx65-pdc": For SDX65
> >  
> >  - reg:
> >  	Usage: required
> > -- 
> > 2.33.1
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
index 98d89e53013d..ce631d853db4 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
@@ -23,6 +23,7 @@  Properties:
 		    - "qcom,sdm845-pdc": For SDM845
 		    - "qcom,sdm8250-pdc": For SM8250
 		    - "qcom,sdm8350-pdc": For SM8350
+		    - "qcom,sdx65-pdc": For SDX65
 
 - reg:
 	Usage: required