From patchwork Tue Oct 21 18:15:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 5127461 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 65703C11AC for ; Tue, 21 Oct 2014 18:16:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 48DB72015A for ; Tue, 21 Oct 2014 18:16:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BADD20123 for ; Tue, 21 Oct 2014 18:16:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755289AbaJUSQW (ORCPT ); Tue, 21 Oct 2014 14:16:22 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:34697 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755176AbaJUSQV (ORCPT ); Tue, 21 Oct 2014 14:16:21 -0400 Received: by mail-wi0-f172.google.com with SMTP id bs8so1903766wib.11 for ; Tue, 21 Oct 2014 11:16:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=bt57SPhTuPAkchlGOnk7tCGiBM4W/dgObeFxyU3TelA=; b=ZZoY5/HsLrh9KzVfJYcGUNF5gjj4r+XZSETHPBVtNU1tbfMofIJG3xHqWpaJTfBSK6 IrsK6FjW+zADe38EN6ycGVyuvvDIW0IZiVMCMvC8MkuHX7C7/2UooK54AyL0pdiRLloy DGheiU1X7TjtaH11zhybvMzmDefjcLyNvVnR3jejBK6LVQk8PrJJPbu+MNAWOV/nI2Ta u8J1fwc4RI1raYmnNQDiFRGXJFqIRDgziSeSytN66OmBdAtkEKAUi6qTFuPPPFmlY1Sz HR5DwY9iloUcMQM53YBZZQ6KT2/sAh8f2VV6Xl5/PBvEkqnmmob223yxftxMLqvNnnvR bIPw== X-Gm-Message-State: ALoCoQkfnBXynEX1L/2L1znfIUCb/V0jJFe7yx+ituA660GS4MSvCgypXm79jtH3Rt1bTGAhZBBB X-Received: by 10.194.8.230 with SMTP id u6mr7011641wja.128.1413915379573; Tue, 21 Oct 2014 11:16:19 -0700 (PDT) Received: from [192.168.1.7] (host-2-99-226-223.as13285.net. [2.99.226.223]) by mx.google.com with ESMTPSA id fa7sm16163466wjd.27.2014.10.21.11.16.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Oct 2014 11:16:18 -0700 (PDT) Message-ID: <5446A2D8.3070204@linaro.org> Date: Tue, 21 Oct 2014 19:15:52 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "Ivan T. Ivanov" , Linus Walleij , Grant Likely , Rob Herring CC: Bjorn Andersson , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v5 3/4] pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver References: <1412181058-29179-1-git-send-email-iivanov@mm-sol.com> <1412181058-29179-4-git-send-email-iivanov@mm-sol.com> In-Reply-To: <1412181058-29179-4-git-send-email-iivanov@mm-sol.com> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Ivan, Just realized that this patch can generate compiler errors due to 3.18 changes in pinmux_ops struct and gpiochip_remove returns void now. Same with drivers/pinctrl/qcom/pinctrl-spmi-pmic-mpp.c On 01/10/14 17:30, Ivan T. Ivanov wrote: > + .enable = pmic_gpio_pinmux_enable, > +}; > > +static int pmic_gpio_remove(struct platform_device *pdev) > +{ > + struct pmic_gpio_state *state = platform_get_drvdata(pdev); > + int ret; > + > + ret = gpiochip_remove(&state->chip); > + if (ret < 0) > + return ret; Thanks, srini --- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-pmic-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-pmic-gpio.c index 493f0d3..0d69758 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-pmic-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-pmic-gpio.c @@ -378,7 +378,7 @@ static const struct pinmux_ops pmic_gpio_pinmux_ops = { .get_functions_count = pmic_gpio_get_functions_count, .get_function_name = pmic_gpio_get_function_name, .get_function_groups = pmic_gpio_get_function_groups, - .enable = pmic_gpio_pinmux_enable, + .set_mux = pmic_gpio_pinmux_enable, }; static int pmic_gpio_config_get(struct pinctrl_dev *pctldev, @@ -907,12 +907,8 @@ err_chip: static int pmic_gpio_remove(struct platform_device *pdev) { struct pmic_gpio_state *state = platform_get_drvdata(pdev); - int ret; - - ret = gpiochip_remove(&state->chip); - if (ret < 0) - return ret; + gpiochip_remove(&state->chip); pinctrl_unregister(state->ctrl); return 0;