From patchwork Wed Mar 20 13:17:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 10861665 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D230A1575 for ; Wed, 20 Mar 2019 13:18:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B81B12877B for ; Wed, 20 Mar 2019 13:18:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ABED029BBB; Wed, 20 Mar 2019 13:18:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53E0A2877B for ; Wed, 20 Mar 2019 13:18:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbfCTNSu (ORCPT ); Wed, 20 Mar 2019 09:18:50 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:37450 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728166AbfCTNSs (ORCPT ); Wed, 20 Mar 2019 09:18:48 -0400 Received: by mail-pg1-f196.google.com with SMTP id q206so1804516pgq.4 for ; Wed, 20 Mar 2019 06:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=TBXOh+qCZb1AbvhplyZXyYZ1SSUAH9q1meg8o/qp39A=; b=Dukqm7YyVqigrw6lDqctSEhs4I4uOFNaCkyh650aKW4VErIT6IyYo4JdyCOTAZzVqx Begg9lvVg1Qp04MW6PF/khuDMDyIVVn+C1xpRe9yUGH2dccr4FPap0UnHzDVTdtjOjxN RzRSwyDTYkb6wBiqGI+ubu3tWOeu9aSTHHfWwoLU4n6ZXBtMJm0CJtAaJ/O51673lv8S WMk2DYft4uGNl1H1TnWjxKEwATy8RrRfFn7AKYfOpQZopuABM8/tyjep1hZ5gBuz4PqP +Gw7Bl3OdyWOMsGxYQyq1tsdH1Xncp7n9lVeQRn5WnoMjGUqu+6BEEyUfqIokqh1WCc/ jX1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=TBXOh+qCZb1AbvhplyZXyYZ1SSUAH9q1meg8o/qp39A=; b=HBzH99mhqI+9k5sLt0kGUJGI7ghELoZhijgbXNVZcln084avp7Tbp0rRKJAhlSnP+b F+vH7lNwkqZQVMIKOSw7PpedbnSOU8RI3SLdGPiJ4nSbSk+WCU+RYrSl4XGN4Xh5KmkZ kPEqZJUw5iKmtcwOn6FpnYdSyg5M6MC6fg1RDEYrWU4F3I4eW3ACdqvOfY8dprFPpk9S 6O98pLZ/IDXf+9kFJJnmaDu9sWEvsiiSpXdrSsHdL7QI9pTeVMXhDKa7NybZCRdz3flM 1KtNtIgd2mKYLYYNRMF/ntKvP3a1xBc8WD95bAEtA0+oEuANEB3BDUi+O/8fhiFrRzXL 9czw== X-Gm-Message-State: APjAAAWAjnorTVvFsG0e7evAKJAbjo056ksffkhbrPuuSUlqPE+1IBkO nKyO8SGe7LP9Ls1poEa3LGy9QA== X-Google-Smtp-Source: APXvYqy7nez153SYADd3MZBc+TbCbOkMEU3qZ4JJ9PxLVlIEUP8rdhvr96Ztjrg3gW8UXgiI0R1QoQ== X-Received: by 2002:a63:4a4d:: with SMTP id j13mr7242489pgl.16.1553087927781; Wed, 20 Mar 2019 06:18:47 -0700 (PDT) Received: from localhost ([114.143.122.221]) by smtp.gmail.com with ESMTPSA id n65sm6654476pfb.160.2019.03.20.06.18.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Mar 2019 06:18:46 -0700 (PDT) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, andy.gross@linaro.org, Daniel Lezcano , David Brown , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCHv3 06/23] drivers: thermal: tsens: Function prototypes should have argument names Date: Wed, 20 Mar 2019 18:47:46 +0530 Message-Id: <5789c6cda462269f443dfe05a561c098bd81c7ea.1553086065.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP check_patch complains a lot as follows: WARNING: function definition argument 'struct tsens_priv *' should also have an identifier name + int (*init)(struct tsens_priv *); Fix it. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h index 61ca2905ee7a..4d6a406f8dca 100644 --- a/drivers/thermal/qcom/tsens.h +++ b/drivers/thermal/qcom/tsens.h @@ -47,15 +47,15 @@ struct tsens_sensor { */ struct tsens_ops { /* mandatory callbacks */ - int (*init)(struct tsens_priv *); - int (*calibrate)(struct tsens_priv *); - int (*get_temp)(struct tsens_priv *, int, int *); + int (*init)(struct tsens_priv *priv); + int (*calibrate)(struct tsens_priv *priv); + int (*get_temp)(struct tsens_priv *priv, int i, int *temp); /* optional callbacks */ - int (*enable)(struct tsens_priv *, int); - void (*disable)(struct tsens_priv *); - int (*suspend)(struct tsens_priv *); - int (*resume)(struct tsens_priv *); - int (*get_trend)(struct tsens_priv *, int, enum thermal_trend *); + int (*enable)(struct tsens_priv *priv, int i); + void (*disable)(struct tsens_priv *priv); + int (*suspend)(struct tsens_priv *priv); + int (*resume)(struct tsens_priv *priv); + int (*get_trend)(struct tsens_priv *priv, int i, enum thermal_trend *trend); }; enum reg_list { @@ -111,10 +111,10 @@ struct tsens_priv { struct tsens_sensor sensor[0]; }; -char *qfprom_read(struct device *, const char *); -void compute_intercept_slope(struct tsens_priv *, u32 *, u32 *, u32); -int init_common(struct tsens_priv *); -int get_temp_common(struct tsens_priv *, int, int *); +char *qfprom_read(struct device *dev, const char *cname); +void compute_intercept_slope(struct tsens_priv *priv, u32 *pt1, u32 *pt2, u32 mode); +int init_common(struct tsens_priv *priv); +int get_temp_common(struct tsens_priv *priv, int i, int *temp); /* TSENS v1 targets */ extern const struct tsens_plat_data data_8916, data_8974, data_8960;