| Message ID | 5f1ca3bfc45e268f7f9f6e091ba13b8103fb4304.1571314830.git.amit.kucheria@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Initialise thermal framework and cpufreq earlier during boot | expand |
Quoting Amit Kucheria (2019-10-17 05:27:37) > Initialise the clock drivers on sdm845 and qcs404 in core_initcall so we > can have earlier access to cpufreq during booting. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- Acked-by: Stephen Boyd <sboyd@kernel.org> Makes me sad again.
On 17-10-19, 10:47, Stephen Boyd wrote: > Quoting Amit Kucheria (2019-10-17 05:27:37) > > Initialise the clock drivers on sdm845 and qcs404 in core_initcall so we > > can have earlier access to cpufreq during booting. > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > --- > > Acked-by: Stephen Boyd <sboyd@kernel.org> > > Makes me sad again. I am wondering why it makes you sad ? :)
On Mon, Oct 28, 2019 at 10:22:24AM -0700, Stephen Boyd wrote: > Quoting Viresh Kumar (2019-10-17 23:03:45) > > On 17-10-19, 10:47, Stephen Boyd wrote: > > > Quoting Amit Kucheria (2019-10-17 05:27:37) > > > > Initialise the clock drivers on sdm845 and qcs404 in core_initcall so we > > > > can have earlier access to cpufreq during booting. > > > > > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > > > --- > > > > > > Acked-by: Stephen Boyd <sboyd@kernel.org> > > > > > > Makes me sad again. > > > > I am wondering why it makes you sad ? :) > > > > We're playing games with initcall levels :( > +1, which will come back and bite us hard soon :) -- Regards, Sudeep
On 29-10-19, 09:06, Sudeep Holla wrote: > On Mon, Oct 28, 2019 at 10:22:24AM -0700, Stephen Boyd wrote: > > Quoting Viresh Kumar (2019-10-17 23:03:45) > > > On 17-10-19, 10:47, Stephen Boyd wrote: > > > > Quoting Amit Kucheria (2019-10-17 05:27:37) > > > > > Initialise the clock drivers on sdm845 and qcs404 in core_initcall so we > > > > > can have earlier access to cpufreq during booting. > > > > > > > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > > > > --- > > > > > > > > Acked-by: Stephen Boyd <sboyd@kernel.org> > > > > > > > > Makes me sad again. > > > > > > I am wondering why it makes you sad ? :) > > > > > > > We're playing games with initcall levels :( > > > > +1, which will come back and bite us hard soon :) :) I don't like reordering init calls as well, but only when they are used to avoid issues and probe things in a particular order. While the only thing we are doing here is to get things to probe earlier, which isn't wrong IMO :) Lets see if it bites us anytime soon, I would be surprised really :)
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index 96a36f6ff667..20d4258f125b 100644 --- a/drivers/clk/qcom/clk-rpmh.c +++ b/drivers/clk/qcom/clk-rpmh.c @@ -487,7 +487,7 @@ static int __init clk_rpmh_init(void) { return platform_driver_register(&clk_rpmh_driver); } -subsys_initcall(clk_rpmh_init); +core_initcall(clk_rpmh_init); static void __exit clk_rpmh_exit(void) { diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c index bd32212f37e6..9b0c4ce2ef4e 100644 --- a/drivers/clk/qcom/gcc-qcs404.c +++ b/drivers/clk/qcom/gcc-qcs404.c @@ -2855,7 +2855,7 @@ static int __init gcc_qcs404_init(void) { return platform_driver_register(&gcc_qcs404_driver); } -subsys_initcall(gcc_qcs404_init); +core_initcall(gcc_qcs404_init); static void __exit gcc_qcs404_exit(void) { diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c index 95be125c3bdd..49dcff1af2db 100644 --- a/drivers/clk/qcom/gcc-sdm845.c +++ b/drivers/clk/qcom/gcc-sdm845.c @@ -3628,7 +3628,7 @@ static int __init gcc_sdm845_init(void) { return platform_driver_register(&gcc_sdm845_driver); } -subsys_initcall(gcc_sdm845_init); +core_initcall(gcc_sdm845_init); static void __exit gcc_sdm845_exit(void) {
Initialise the clock drivers on sdm845 and qcs404 in core_initcall so we can have earlier access to cpufreq during booting. Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- drivers/clk/qcom/clk-rpmh.c | 2 +- drivers/clk/qcom/gcc-qcs404.c | 2 +- drivers/clk/qcom/gcc-sdm845.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)