| Message ID | 77652.1589836106@turing-police (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | remoteproc: wcss: Fix function call for new API | expand |
On Mon 18 May 14:14 PDT 2020, Valdis Kl??tnieks wrote: > On Mon, 18 May 2020 17:08:26 -0400, "Valdis Kl??tnieks" said: > > commit 8a226e2c71: remoteproc: wcss: add support for rpmsg communication > > > > throws a compile error: > > > > CC [M] drivers/remoteproc/qcom_q6v5_wcss.o > > drivers/remoteproc/qcom_q6v5_wcss.c: In function 'q6v5_wcss_probe': > > Ignore this - was fixed between when I noted the problem and when I sent the mail :) Right, I fixed this a few days back. Thanks for the patch and thanks for confirming that it's fixed! Regards, Bjorn
diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c index 48d16d81f94d..99ecc0e6276e 100644 --- a/drivers/remoteproc/qcom_q6v5_wcss.c +++ b/drivers/remoteproc/qcom_q6v5_wcss.c @@ -560,7 +560,7 @@ static int q6v5_wcss_probe(struct platform_device *pdev) if (ret) goto free_rproc; - qcom_add_glink_subdev(rproc, &wcss->glink_subdev); + qcom_add_glink_subdev(rproc, &wcss->glink_subdev,"q6wcss"); qcom_add_ssr_subdev(rproc, &wcss->ssr_subdev, "q6wcss"); ret = rproc_add(rproc);
commit 8a226e2c71: remoteproc: wcss: add support for rpmsg communication throws a compile error: CC [M] drivers/remoteproc/qcom_q6v5_wcss.o drivers/remoteproc/qcom_q6v5_wcss.c: In function 'q6v5_wcss_probe': drivers/remoteproc/qcom_q6v5_wcss.c:563:2: error: too few arguments to function 'qcom_add_glink_subdev' qcom_add_glink_subdev(rproc, &wcss->glink_subdev); ^~~~~~~~~~~~~~~~~~~~~ In file included from drivers/remoteproc/qcom_q6v5_wcss.c:16: drivers/remoteproc/qcom_common.h:35:6: note: declared here void qcom_add_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink, ^~~~~~~~~~~~~~~~~~~~~ Update to API change from commit cd9fc8f: remoteproc: qcom: Pass ssr_name to glink subdevice Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>