| Message ID | 8315045c-471a-1ce3-7558-efaaf2cd5406@free.fr (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | UFS on APQ8098/MSM8998 | expand |
On 2/4/2019 10:39 AM, Marc Gonzalez wrote: > Use same init sequence as sdm845. > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > --- Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> > drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index b4006818e1b6..39b9c31b67d0 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -1735,6 +1735,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = { > }, { > .compatible = "qcom,msm8996-qmp-usb3-phy", > .data = &msm8996_usb3phy_cfg, > + }, { > + .compatible = "qcom,msm8998-qmp-ufs-phy", > + .data = &sdm845_ufsphy_cfg, > }, { > .compatible = "qcom,ipq8074-qmp-pcie-phy", > .data = &ipq8074_pciephy_cfg, >
Hi, On 04/02/19 11:40 PM, Jeffrey Hugo wrote: > On 2/4/2019 10:39 AM, Marc Gonzalez wrote: >> Use same init sequence as sdm845. >> >> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> >> --- > > Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> I don't seem to have the dt-binding patch in my inbox. Can you resend them please? Thanks Kishon > >> drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c >> b/drivers/phy/qualcomm/phy-qcom-qmp.c >> index b4006818e1b6..39b9c31b67d0 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c >> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c >> @@ -1735,6 +1735,9 @@ static const struct of_device_id >> qcom_qmp_phy_of_match_table[] = { >> }, { >> .compatible = "qcom,msm8996-qmp-usb3-phy", >> .data = &msm8996_usb3phy_cfg, >> + }, { >> + .compatible = "qcom,msm8998-qmp-ufs-phy", >> + .data = &sdm845_ufsphy_cfg, >> }, { >> .compatible = "qcom,ipq8074-qmp-pcie-phy", >> .data = &ipq8074_pciephy_cfg, >> > >
On 06/02/2019 13:39, Kishon Vijay Abraham I wrote:
> I don't seem to have the dt-binding patch in my inbox. Can you resend them please?
Jeffrey pointed out a few deficiencies in the series.
I'll CC you on the entire upcoming v4 series.
Regards.
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index b4006818e1b6..39b9c31b67d0 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -1735,6 +1735,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = { }, { .compatible = "qcom,msm8996-qmp-usb3-phy", .data = &msm8996_usb3phy_cfg, + }, { + .compatible = "qcom,msm8998-qmp-ufs-phy", + .data = &sdm845_ufsphy_cfg, }, { .compatible = "qcom,ipq8074-qmp-pcie-phy", .data = &ipq8074_pciephy_cfg,
Use same init sequence as sdm845. Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> --- drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++ 1 file changed, 3 insertions(+)