From patchwork Mon Nov 16 21:43:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7631121 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DAC2A9F1C2 for ; Mon, 16 Nov 2015 21:49:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0EC43205B1 for ; Mon, 16 Nov 2015 21:49:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EAE820525 for ; Mon, 16 Nov 2015 21:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbbKPVtR (ORCPT ); Mon, 16 Nov 2015 16:49:17 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:59138 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbbKPVtQ (ORCPT ); Mon, 16 Nov 2015 16:49:16 -0500 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0LzTlq-1aSoKB3f9u-014oPq; Mon, 16 Nov 2015 22:43:53 +0100 From: Arnd Bergmann To: Eduardo Valentin Cc: Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Ivan T. Ivanov" , David Collins , linux-arm-msm@vger.kernel.org Subject: [PATCH] Revert "thermal: qcom_spmi: allow compile test" Date: Mon, 16 Nov 2015 22:43:50 +0100 Message-ID: <9183915.mBPRJBbpGR@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:5gvu7wcW26AlGtQQ8PdFHanS+ZGeXa8IxS7+SuloFau1QcvPemR Gwp+oUUGV3ySw9gUHap9808h3iERaOZQSjizTk6PpPUqI+3glf64Pxg4RVpxMw+aqZcrI2t n2+1jwB8WYPvabU8sVXncPYcDJVih/+4qJEQSDQcZmZtBC1IP5c3R/2s8i0785rDrWoIoXA NvICXCGx7gbjVeAa2PKzw== X-UI-Out-Filterresults: notjunk:1; V01:K0:ImyPk9fGD1k=:cysiGhfGwVtXGu188uHPdz Zt7Tz5QOAbf59dEgweINqGRY5dgTufkXie7PXI4q6igmO4VXNiYzzM9k0sxBrxnxjmRaqRCYI vzz9VUiM+mRZ4WNa36TaEQxB5X17LbjSTkQfq6bKiP+zN12QYaj29AcH7OLnExNltKC2wSw8p I+4aKbZduQ5fOuugIL08qtt8CadJeUIWSfpqzmqir9GqqA1roOJt+2ZAr4uqOXlyBzxlqcjUW IxDpd/b6FkO+5ugLM7ZMQk+nuehaFpa/sO4GbXCQN8YsZ9bfCOn0MCebJVGi6KMPzTCnqMjpH aLGEo6jOidE5HaCKXsTyqmuuVMtzIIc5Z6CGjIz0IkbxakI4TmK4xZMnQXMLLOQXPXF7ysv9E V/PnstXcEwnEZmCoqQWJR0OXhhQ58nRYUNMRWkRu+rSUuSJxgtXBBNM+yW1IZ7Atf0y8MRmO9 6D3jpAh70uHz0XMOIqAUDUs7sLHNxPT9uQ9fiLHX86j7TM8R2FIOM32oegd70egkmlgfUN6g1 VnAzqQXOR/TdiLj/AzRymAz2j4TfyG98OPLs+TPdpz2G+OLE9XRulGrVpVUojmRd4wq+vGn2x qER0OY0YCgpVbiEvZXq4Nps0M8AOHuhqI03hlzj6mNjl6VTF4j/uxlJRg4KnkjVsCl5SRH2nR ZggLSzsnmTCq+1sSxqeumqDD+uVXoWWBm+m/+daH6scP1cat0SmCSQ6/xtcAkdc7KGgiNe3mS 7GRRt9/nvZ+obSFA Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This just caused build errors: warning: (QCOM_SPMI_TEMP_ALARM) selects REGMAP_SPMI which has unmet direct dependencies (SPMI) drivers/built-in.o: In function `regmap_spmi_ext_gather_write': :(.text+0x609b0): undefined reference to `spmi_ext_register_write' :(.text+0x609f0): undefined reference to `spmi_ext_register_writel' While it's generally a good idea to allow compile testing, in this case, it just doesn't work, so reverting the patch that introduced the compile-test variant seems the most appropriate solution. Note that SPIMI also has a 'depends on ARCH_QCOM || COMPILE_TEST' statement, so we should be able to enable SPMI on all architectures for compile testing already. Signed-off-by: Arnd Bergmann Fixes: cb7fb4d34202 ("thermal: qcom_spmi: allow compile test") --- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 2e7524f0f3f7..6045b17d0e00 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -381,7 +381,7 @@ endmenu config QCOM_SPMI_TEMP_ALARM tristate "Qualcomm SPMI PMIC Temperature Alarm" - depends on OF && (SPMI || COMPILE_TEST) && IIO + depends on OF && SPMI && IIO select REGMAP_SPMI help This enables a thermal sysfs driver for Qualcomm plug-and-play (QPNP)