From patchwork Thu Aug 14 16:53:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Bird X-Patchwork-Id: 4724841 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 864A89F319 for ; Thu, 14 Aug 2014 16:53:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C95D220108 for ; Thu, 14 Aug 2014 16:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E07572011B for ; Thu, 14 Aug 2014 16:53:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908AbaHNQxO (ORCPT ); Thu, 14 Aug 2014 12:53:14 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:58786 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753382AbaHNQxN (ORCPT ); Thu, 14 Aug 2014 12:53:13 -0400 Received: by mail-we0-f173.google.com with SMTP id q58so1345874wes.4 for ; Thu, 14 Aug 2014 09:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=9Fa42Wixz5+UDYumxjrz4D0dt9EiBE5y+w+acGnfQJc=; b=n5rRo4dQeFIAlSTr9ye9ZC/uXFeArMWzygWhAeVUNzVBZ5KDoH2Lp9/IErw75aA2qh 0Tnk6Pwe86gWv1Ixcd5iDa9ohe+bvBmWBnSEvHYCvFGx3jIsvrkkXmCtFyckCqjuTT1z 6btzt1yfAgsG9wONW20nJ8Ul1QfvPGKapILeOyxZJRmVKgpfs7SZ/IyAkHoHrxILAMAM jx6TNm1H6fwD63Axz7bBN5CuHqwtM+sanuCoh3X/Ycq9Gkx6eoHeb7CNmkk/wlHmE0Ws eHDYYtEVUdV4iabbAeIr3gE66AjSTapzK/5dR05dJfX7GeC6meKN6yKTZC89Qh6WFxFh CZjg== MIME-Version: 1.0 X-Received: by 10.180.101.65 with SMTP id fe1mr48382027wib.53.1408035190873; Thu, 14 Aug 2014 09:53:10 -0700 (PDT) Received: by 10.216.6.9 with HTTP; Thu, 14 Aug 2014 09:53:10 -0700 (PDT) In-Reply-To: References: Date: Thu, 14 Aug 2014 09:53:10 -0700 Message-ID: Subject: Fwd: Status of chipidea msm USB reset patch From: Tim Bird To: "balbi@ti.com" , "Ivan T. Ivanov" , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Ping. Anybody know the status of this patch? Is it queued in someone's tree? Without it the USB driver for the Qualcomm 8974 (hsusb phy) doesn't work (at least for me). It looks like it got dropped from Ivan's original patch series, back in May. ---------- Forwarded message ---------- From: Tim Bird Date: Fri, Jul 25, 2014 at 2:38 PM Subject: Status of chipidea msm USB reset patch To: linux-arm-msm@vger.kernel.org, balbi@ti.com, "Ivan T. Ivanov" Ivan and Felipe, Do you know the status of the patch below? It was part of Ivan's USB patch set, which got mainlined recently. However, this patch did not show up in Linus' tree. Is it in another tree on it's way, or does it need a re-submission? I was recently testing the MSM USB gadget driver on the Dragonboard 800 (with a Qualcomm 8974 processor), and without this patch the USB hardware does not come up properly. Thanks, -- Tim Subject: [PATCH] usb: chipidea: msm: Use USB PHY API to control PHY state PHY drivers keep track of the current state of the hardware, so don't change PHY settings under it. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) dev_dbg(dev, "unknown ci_hdrc event\n"); -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index d72b9d2..81de834 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c +++ b/drivers/usb/chipidea/ci_hdrc_msm.c @@ -20,13 +20,11 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event) { struct device *dev = ci->gadget.dev.parent; - int val; switch (event) { case CI_HDRC_CONTROLLER_RESET_EVENT: dev_dbg(dev, "CI_HDRC_CONTROLLER_RESET_EVENT received\n"); - writel(0, USB_AHBBURST); - writel(0, USB_AHBMODE); + usb_phy_init(ci->transceiver); break; case CI_HDRC_CONTROLLER_STOPPED_EVENT: dev_dbg(dev, "CI_HDRC_CONTROLLER_STOPPED_EVENT received\n"); @@ -34,10 +32,7 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event) * Put the transceiver in non-driving mode. Otherwise host * may not detect soft-disconnection. */ - val = usb_phy_io_read(ci->transceiver, ULPI_FUNC_CTRL); - val &= ~ULPI_FUNC_CTRL_OPMODE_MASK; - val |= ULPI_FUNC_CTRL_OPMODE_NONDRIVING; - usb_phy_io_write(ci->transceiver, val, ULPI_FUNC_CTRL); + usb_phy_notify_disconnect(ci->transceiver, USB_SPEED_UNKNOWN); break; default: