From patchwork Mon Aug 11 12:49:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 4707141 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 79AA0C0338 for ; Mon, 11 Aug 2014 12:49:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BB51B2010F for ; Mon, 11 Aug 2014 12:49:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9FFE2010E for ; Mon, 11 Aug 2014 12:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbaHKMtI (ORCPT ); Mon, 11 Aug 2014 08:49:08 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:47169 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbaHKMtH (ORCPT ); Mon, 11 Aug 2014 08:49:07 -0400 Received: by mail-oa0-f48.google.com with SMTP id m1so5951520oag.7 for ; Mon, 11 Aug 2014 05:49:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=rdKwhdwZxSxJQUUzI+9XYdYaOP9ed5FEZzgJfxePrdU=; b=T1WtAO83hQQkqrsSsBhjuG3Ld9srabl96lb7sJRbxOcJ2nPhQ3V4jX2BnzWbk1qNSq Ya6HVrVX1pQzNkWpxAYwYKwJKBu6prh952UR9OgDXLMMCxgm+eNZ0M3Pjdy9bl0ZxLT0 8kuIPrt5KPIrp/cn2ZlswwNmxgrT5N0h0hv1W5+HdB9DP60dNf33GUWCXg0O5Sobadyx 618qrOZAyLSorxvSjMqnltOtKySIAMWzKpHOmlpIweLuCIPcgV8XUnsYf/iYpDmUNfxo y0om05UQ1bgLv89vU5ZdSv6sJlVgJcRAS4I638tMa1wncZqa/Ulk4TkppGUaDm1jiMGE vFvQ== X-Gm-Message-State: ALoCoQnT0+NwBPS1ToyA0M+wCg5n3P43WcdB3UkqPStclPQXxplsN03xY0BXWL3Ycui1+Abvj3Th MIME-Version: 1.0 X-Received: by 10.60.175.138 with SMTP id ca10mr50396867oec.15.1407761346130; Mon, 11 Aug 2014 05:49:06 -0700 (PDT) Received: by 10.182.33.33 with HTTP; Mon, 11 Aug 2014 05:49:06 -0700 (PDT) In-Reply-To: References: Date: Mon, 11 Aug 2014 14:49:06 +0200 Message-ID: Subject: Re: Failure booting DragonBoard APQ8060 after mach-qcom introduction From: Linus Walleij To: Kumar Gala , "linux-arm-msm@vger.kernel.org" Cc: Bjorn Andersson Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Aug 11, 2014 at 1:42 PM, Linus Walleij wrote: > On Mon, Aug 11, 2014 at 1:21 PM, Linus Walleij wrote: > >> The symptom is that not even earlyprints come up if I put some >> printascii() in start_kernel. > > Bah that was me not realizing that the defaults for DEBUG_UART_PHYS > and DEBUG_UART_VIRT has to be set up properly... now I get the > earlyprints. > > It seems to hang in the gsbi driver probe, off to debug. It appears that this oneliner gets the kernel booting again: The kernel hangs during disable/unprepare of the hclk for the GSBI. Turning off hclk's could be dangerous if there are vital system components using the hclk which does not yet have a reference taken in the kernel, due to missing drivers or similar. Any ideas? Yours, Linus Walleij Tested-by: Linus Walleij --- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c index 447458e696a9..1759a3c9140a 100644 --- a/drivers/soc/qcom/qcom_gsbi.c +++ b/drivers/soc/qcom/qcom_gsbi.c @@ -57,7 +57,7 @@ static int gsbi_probe(struct platform_device *pdev) /* make sure the gsbi control write is not reordered */ wmb(); - clk_disable_unprepare(hclk); + //clk_disable_unprepare(hclk); return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); }