| Message ID | DS7PR19MB8883C8E61B02269AAD7D8C1C9DC72@DS7PR19MB8883.namprd19.prod.outlook.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for IPQ5018 tsens | expand |
On 21/02/2025 07:52, George Moussalem wrote: > From: Sricharan Ramabadhran <quic_srichara@quicinc.com> > > Document the QFPROM block found on IPQ5018 > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > Signed-off-by: George Moussalem <george.moussalem@outlook.com> Any explanation why you are sending this? Why there is no cover letter? This is 1.5 year old work, so I assume Qualcomm is abandoning this chip and maybe there is no point in merging this in the first place? Best regards, Krzysztof
I can't speak on behalf of Qualcomm as to whether they've abandoned this chip. However, there are plenty of routers/APs that use this chip and support for it and some IPQ5018 based devices has recently been added to OpenWrt. Hence, I'm picking up where Qualcomm has left off and would like to send as much as possible upstream for mainline support. I've included a cover letter here: https://lore.kernel.org/all/DS7PR19MB8883BE38C2B500D03213747A9DC72@DS7PR19MB8883.namprd19.prod.outlook.com/
I can't speak on behalf of Qualcomm as to whether they've abandoned this chip. However, there are plenty of routers/APs that use this chip and support for it and some IPQ5018 based devices has recently been added to OpenWrt. Hence, I'm picking up where Qualcomm has left off and would like to send as much as possible upstream for mainline support. I've included a cover letter here: https://lore.kernel.org/all/DS7PR19MB8883BE38C2B500D03213747A9DC72@DS7PR19MB8883.namprd19.prod.outlook.com/
On 21/02/2025 11:08, George Moussalem wrote: > I can't speak on behalf of Qualcomm as to whether they've abandoned this chip. > However, there are plenty of routers/APs that use this chip and support for it and some IPQ5018 based devices has recently been added to OpenWrt. > Hence, I'm picking up where Qualcomm has left off and would like to send as much as possible upstream for mainline support. That's fine, but should be mentioned in cover letter. Anytime you take someone else's patchset, please say shortly why, so maintainers won't deal with duplicated submissions for example. > > I've included a cover letter here: https://lore.kernel.org/all/DS7PR19MB8883BE38C2B500D03213747A9DC72@DS7PR19MB8883.namprd19.prod.outlook.com/ Wasn't in this thread, so that's another issue. Anyway, no need to resend just for any of the above. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml index 39c209249c9c..de262f3153ed 100644 --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml @@ -19,6 +19,7 @@ properties: - enum: - qcom,apq8064-qfprom - qcom,apq8084-qfprom + - qcom,ipq5018-qfprom - qcom,ipq5332-qfprom - qcom,ipq5424-qfprom - qcom,ipq6018-qfprom