| Message ID | MN2PR02MB702479BBA7FE8757E577CA6DD9829@MN2PR02MB7024.namprd02.prod.outlook.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for Xiaomi Poco F1 EBBG variant | expand |
On Fri 08 Jul 06:12 CDT 2022, Joel Selvaraj wrote: > Make the display panel nodes generic. The tianma and ebbg variant will > set the compatabile property as per the display model they use. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> > --- > .../boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > index d88dc07205f7..634999cf8987 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > @@ -221,8 +221,8 @@ &dsi0 { > status = "okay"; > vdda-supply = <&vreg_l26a_1p2>; > > - panel@0 { > - compatible = "tianma,fhd-video"; > + display_panel: panel@0 { > + status = "disabled"; Please make "status" the last property defined in the node. Same comment on the next 2 patches. Thanks, Bjorn > reg = <0>; > vddio-supply = <&vreg_l14a_1p8>; > vddpos-supply = <&lab>; > @@ -235,7 +235,7 @@ panel@0 { > reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; > > port { > - tianma_nt36672a_in_0: endpoint { > + panel_in_0: endpoint { > remote-endpoint = <&dsi0_out>; > }; > }; > @@ -243,7 +243,7 @@ tianma_nt36672a_in_0: endpoint { > }; > > &dsi0_out { > - remote-endpoint = <&tianma_nt36672a_in_0>; > + remote-endpoint = <&panel_in_0>; > data-lanes = <0 1 2 3>; > }; > > -- > 2.36.1 >
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi index d88dc07205f7..634999cf8987 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi @@ -221,8 +221,8 @@ &dsi0 { status = "okay"; vdda-supply = <&vreg_l26a_1p2>; - panel@0 { - compatible = "tianma,fhd-video"; + display_panel: panel@0 { + status = "disabled"; reg = <0>; vddio-supply = <&vreg_l14a_1p8>; vddpos-supply = <&lab>; @@ -235,7 +235,7 @@ panel@0 { reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; port { - tianma_nt36672a_in_0: endpoint { + panel_in_0: endpoint { remote-endpoint = <&dsi0_out>; }; }; @@ -243,7 +243,7 @@ tianma_nt36672a_in_0: endpoint { }; &dsi0_out { - remote-endpoint = <&tianma_nt36672a_in_0>; + remote-endpoint = <&panel_in_0>; data-lanes = <0 1 2 3>; };
Make the display panel nodes generic. The tianma and ebbg variant will set the compatabile property as per the display model they use. Signed-off-by: Joel Selvaraj <jo@jsfamily.in> --- .../boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)