| Message ID | SG2PR03MB5006CBD49DB3052D57A6ABF0CC819@SG2PR03MB5006.apcprd03.prod.outlook.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2,v3,1/2] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family | expand |
On Tue, Jul 05, 2022 at 10:57:47AM +0800, Jimmy Chen wrote: > This adds a LTE skus for Chromebook Villager to the yaml. Your subject is wrong. This is not a .dts file change. Use 'git log --oneline' for inspiration as to what the subject should look like for this file/directory. > > Signed-off-by: Jimmy Chen <jinghung.chen3@hotmail.com> > --- > > The format of the added items is based on the below document. > Documentation/arm/google/chromebook-boot-flow.rst > > Changes in v2: > - Update the patch title and the commit message > Changes in v3: > - Update patch title > > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 4dd18fbf20b68..a136b1389c2ac 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -529,11 +529,26 @@ properties: > - const: google,herobrine > - const: qcom,sc7280 > > + - description: Google Villager (rev0) > + items: > + - const: google,villager-rev0 > + - const: qcom,sc7280 > + > - description: Google Villager (newest rev) > items: > - const: google,villager > - const: qcom,sc7280 > > + - description: Google Villager with LTE (rev0) > + items: > + - const: google,villager-rev0-sku0 > + - const: qcom,sc7280 > + > + - description: Google Villager with LTE (newest rev) > + items: > + - const: google,villager-sku0 > + - const: qcom,sc7280 > + > - items: > - enum: > - lenovo,flex-5g > -- > 2.25.1 > >
On 05/07/2022 04:57, Jimmy Chen wrote: > This adds a LTE skus for Chromebook Villager to the yaml. > > Signed-off-by: Jimmy Chen <jinghung.chen3@hotmail.com> > --- > > The format of the added items is based on the below document. > Documentation/arm/google/chromebook-boot-flow.rst > > Changes in v2: > - Update the patch title and the commit message > Changes in v3: > - Update patch title It's still wrong. Not mentioning incorrect patch formatting. You ignored my comment from previous version. Please respond to it. If you prefer to ignore it, then it is a NAK. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 4dd18fbf20b68..a136b1389c2ac 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -529,11 +529,26 @@ properties: - const: google,herobrine - const: qcom,sc7280 + - description: Google Villager (rev0) + items: + - const: google,villager-rev0 + - const: qcom,sc7280 + - description: Google Villager (newest rev) items: - const: google,villager - const: qcom,sc7280 + - description: Google Villager with LTE (rev0) + items: + - const: google,villager-rev0-sku0 + - const: qcom,sc7280 + + - description: Google Villager with LTE (newest rev) + items: + - const: google,villager-sku0 + - const: qcom,sc7280 + - items: - enum: - lenovo,flex-5g
This adds a LTE skus for Chromebook Villager to the yaml. Signed-off-by: Jimmy Chen <jinghung.chen3@hotmail.com> --- The format of the added items is based on the below document. Documentation/arm/google/chromebook-boot-flow.rst Changes in v2: - Update the patch title and the commit message Changes in v3: - Update patch title --- Documentation/devicetree/bindings/arm/qcom.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+)