| Message ID | SY7P282MB3787F073ED6E860E820C6CDDB202A@SY7P282MB3787.AUSP282.PROD.OUTLOOK.COM (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | arm64: dts: qcom: sm8150: Fix the I2C7 interrupt | expand |
On 24.07.2023 18:21, qaz6750 wrote: > I2C6 and I2C7 use the same interrupts, which is incorrect. > In the downstream kernel, I2C7 has interrupts of 608 instead of 607. > > Signed-off-by: qaz6750 <qaz6750@outlook.com> > --- Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes") Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > index 18c822abd..214f6e028 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -1231,7 +1231,7 @@ i2c7: i2c@89c000 { > dma-names = "tx", "rx"; > pinctrl-names = "default"; > pinctrl-0 = <&qup_i2c7_default>; > - interrupts = <GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>; > #address-cells = <1>; > #size-cells = <0>; > status = "disabled";
On 24/07/2023 18:29, Konrad Dybcio wrote: > On 24.07.2023 18:21, qaz6750 wrote: >> I2C6 and I2C7 use the same interrupts, which is incorrect. >> In the downstream kernel, I2C7 has interrupts of 608 instead of 607. >> >> Signed-off-by: qaz6750 <qaz6750@outlook.com> >> --- > Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes") > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> But we also need full name or known identity, not anonymous contribution. Best regards, Krzysztof
On 24.07.2023 18:52, Krzysztof Kozlowski wrote: > On 24/07/2023 18:29, Konrad Dybcio wrote: >> On 24.07.2023 18:21, qaz6750 wrote: >>> I2C6 and I2C7 use the same interrupts, which is incorrect. >>> In the downstream kernel, I2C7 has interrupts of 608 instead of 607. >>> >>> Signed-off-by: qaz6750 <qaz6750@outlook.com> >>> --- >> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes") >> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > But we also need full name or known identity, not anonymous contribution. Ack, I overlooked that. Konrad
On 25.07.2023 9:44, qaz6750 wrote: >On 24.07.2023 18:52, Krzysztof Kozlowski wrote: >> On 24/07/2023 18:29, Konrad Dybcio wrote: >>> On 24.07.2023 18:21, qaz6750 wrote: >>>> I2C6 and I2C7 use the same interrupts, which is incorrect. >>>> In the downstream kernel, I2C7 has interrupts of 608 instead of 607. >>>> >>>> Signed-off-by: qaz6750 <qaz6750@outlook.com> >>>> --- >>> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes") >>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> >> But we also need full name or known identity, not anonymous contribution. >Ack, I overlooked that. Is it to modify my "Signed-off-by"? I'm sorry I didn't use full name according to the regulations. I think my full name is zeyan li Thanks, qaz6750
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 18c822abd..214f6e028 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -1231,7 +1231,7 @@ i2c7: i2c@89c000 { dma-names = "tx", "rx"; pinctrl-names = "default"; pinctrl-0 = <&qup_i2c7_default>; - interrupts = <GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>; #address-cells = <1>; #size-cells = <0>; status = "disabled";
I2C6 and I2C7 use the same interrupts, which is incorrect. In the downstream kernel, I2C7 has interrupts of 608 instead of 607. Signed-off-by: qaz6750 <qaz6750@outlook.com> --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)