| Message ID | TYZPR01MB55564BE24CE8718DBD4644A2C9762@TYZPR01MB5556.apcprd01.prod.exchangelabs.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: ipq5018-rdp432-c2: correct board name | expand |
On 1/21/2024 6:22 PM, Ziyang Huang wrote: > According to Qualcomm document: > MP03.1 is RDP404 > RDP432 is MP03.5 > > Signed-off-by: Ziyang Huang <hzyitc@outlook.com> > --- > arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts > index 074b78d7939c..f7e8b5af6b44 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts > +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause > /* > - * IPQ5018 MP03.1-C2 board device tree source > + * IPQ5018 MP03.5-C2 board device tree source I suggest to use the RDP number itself here... > * > * Copyright (c) 2023 The Linux Foundation. All rights reserved. > */
在 2024/1/23 0:03, Kathiravan Thirumoorthy 写道: > > > On 1/21/2024 6:22 PM, Ziyang Huang wrote: >> According to Qualcomm document: >> MP03.1 is RDP404 >> RDP432 is MP03.5 >> >> Signed-off-by: Ziyang Huang <hzyitc@outlook.com> >> --- >> arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> index 074b78d7939c..f7e8b5af6b44 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> @@ -1,6 +1,6 @@ >> // SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause >> /* >> - * IPQ5018 MP03.1-C2 board device tree source >> + * IPQ5018 MP03.5-C2 board device tree source > > > I suggest to use the RDP number itself here... Here is an embarrassing thing. AP/MPxx.x name is more common in the entire QSDK while RDP number is almost never appeared. > > >> * >> * Copyright (c) 2023 The Linux Foundation. All rights reserved. >> */
On 1/22/2024 10:27 PM, Ziyang Huang wrote: > 在 2024/1/23 0:03, Kathiravan Thirumoorthy 写道: >> >> >> On 1/21/2024 6:22 PM, Ziyang Huang wrote: >>> According to Qualcomm document: >>> MP03.1 is RDP404 >>> RDP432 is MP03.5 >>> >>> Signed-off-by: Ziyang Huang <hzyitc@outlook.com> >>> --- >>> arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >>> b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >>> index 074b78d7939c..f7e8b5af6b44 100644 >>> --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >>> +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >>> @@ -1,6 +1,6 @@ >>> // SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause >>> /* >>> - * IPQ5018 MP03.1-C2 board device tree source >>> + * IPQ5018 MP03.5-C2 board device tree source >> >> >> I suggest to use the RDP number itself here... > > Here is an embarrassing thing. AP/MPxx.x name is more common in the > entire QSDK while RDP number is almost never appeared. That was the case but not anymore. We decided to switch to RDP number instead of AP/XXXX.. So it would better if we stick with RDP number for consistency. > >> >> >>> * >>> * Copyright (c) 2023 The Linux Foundation. All rights reserved. >>> */ >
diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts index 074b78d7939c..f7e8b5af6b44 100644 --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause /* - * IPQ5018 MP03.1-C2 board device tree source + * IPQ5018 MP03.5-C2 board device tree source * * Copyright (c) 2023 The Linux Foundation. All rights reserved. */
According to Qualcomm document: MP03.1 is RDP404 RDP432 is MP03.5 Signed-off-by: Ziyang Huang <hzyitc@outlook.com> --- arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)