From patchwork Thu Feb 28 12:21:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 10832907 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7E8F21390 for ; Thu, 28 Feb 2019 12:27:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71CE22EC14 for ; Thu, 28 Feb 2019 12:27:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6643B2EC25; Thu, 28 Feb 2019 12:27:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 125C92EC21 for ; Thu, 28 Feb 2019 12:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731257AbfB1M1D (ORCPT ); Thu, 28 Feb 2019 07:27:03 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40498 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727974AbfB1M1D (ORCPT ); Thu, 28 Feb 2019 07:27:03 -0500 Received: by mail-wr1-f67.google.com with SMTP id q1so21755214wrp.7 for ; Thu, 28 Feb 2019 04:27:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=DhOH74k9WLUHZ9bc4R59OvEiqm0NxoNRQ6D2mdU8GNA=; b=irnNzAIpeG/Q0pGh4DtzlM80WIT9F4seVwCL3A8RRCFJVmt2gq1QdrN4ogqjZVYHxD JaXpo4aoM3Du5s+zM4S9d5qsO5gRFlhz7XR71CvRD1yq8VcHxrhZWXtsG3HmvZ1pmJYU OCfK4t+P4tp5rgtjmCv+xjtwt8WcEuvLIk92fpDZE7N2Sk5AiqcKKpg4HUxIa0blo0OM 6Ar/pHmQIrbfDeVEM6Kbl8ZtzsQVB3gvINqvMfDPq8/929hpTT7RurhmrWAHKvUD5RVD o/+qx9wN4YDVteKjc+i2+LdOJxhHIxi5FHDQPnnwW5kq+1Fhqsyy08PJrUdXsgtFMHzq 6OAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=DhOH74k9WLUHZ9bc4R59OvEiqm0NxoNRQ6D2mdU8GNA=; b=Rizmx98u/Gn2e5lAvnXWEBMxZEBFCNk67g8FKNX8tigMPXQyb0ZjFgwy2Rcsfeav+s PcEk7z55PBNKYvme0nDVS+pcijHzXXdj1EtV+fHN3wen4uenu1RIIxeoQYR3vRlpifHl KtOll6i7VgHhxAb+Ng1CsWSN/9A1KJv45zNpos7yGv0JLbVra+aTNOD16kx9ZQrHlys5 HrOYzXeKVBm5XCTri20ZEear1C4Fgx62Wlxa+2XtG+EqhaLRgB7SchKCwPWdznFB0M9W /AwROJpU7zIw8/a1aUQ4OZ8R1CFi5qlfN1sOrohHQpzKFenNYG9R1dNChRAm2kkWD+bS oXhA== X-Gm-Message-State: APjAAAUqr6YQ2a2ZVWWzHqtOdVgA+pmpnKmKmV/t1XeLv47R6DYm0Twr vtxHdUkbjhgkeRgIwziStAG42A== X-Google-Smtp-Source: APXvYqzpGNun1JhC1FD+F4k3rpkW72/KAODbc5co4UvHpiEeL91z7FsN00xhK+VMJz9tIAkZMmkmNw== X-Received: by 2002:a5d:4702:: with SMTP id y2mr6683446wrq.149.1551356821348; Thu, 28 Feb 2019 04:27:01 -0800 (PST) Received: from localhost ([49.248.54.130]) by smtp.gmail.com with ESMTPSA id c2sm25070024wrt.93.2019.02.28.04.26.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 04:27:00 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, andy.gross@linaro.org, Daniel Lezcano , David Brown , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v2 11/24] drivers: thermal: tsens: Save reference to the device pointer and use it Date: Thu, 28 Feb 2019 17:51:01 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Code cleanup making it easier to read Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index a82e4c928a78..aae3d71d7eed 100644 --- a/drivers/thermal/qcom/tsens-common.c +++ b/drivers/thermal/qcom/tsens-common.c @@ -119,6 +119,7 @@ static const struct regmap_config tsens_srot_config = { int __init init_common(struct tsens_priv *priv) { void __iomem *tm_base, *srot_base; + struct device *dev = priv->dev; struct resource *res; u32 enabled; int ret, i, j; @@ -135,7 +136,7 @@ int __init init_common(struct tsens_priv *priv) if (IS_ERR(srot_base)) return PTR_ERR(srot_base); - priv->srot_map = devm_regmap_init_mmio(priv->dev, srot_base, + priv->srot_map = devm_regmap_init_mmio(dev, srot_base, &tsens_srot_config); if (IS_ERR(priv->srot_map)) return PTR_ERR(priv->srot_map); @@ -150,11 +151,11 @@ int __init init_common(struct tsens_priv *priv) if (IS_ERR(tm_base)) return PTR_ERR(tm_base); - priv->tm_map = devm_regmap_init_mmio(priv->dev, tm_base, &tsens_config); + priv->tm_map = devm_regmap_init_mmio(dev, tm_base, &tsens_config); if (IS_ERR(priv->tm_map)) return PTR_ERR(priv->tm_map); - priv->rf[TSENS_EN] = devm_regmap_field_alloc(priv->dev, priv->srot_map, + priv->rf[TSENS_EN] = devm_regmap_field_alloc(dev, priv->srot_map, priv->fields[TSENS_EN]); if (IS_ERR(priv->rf[TSENS_EN])) return PTR_ERR(priv->rf[TSENS_EN]); @@ -162,24 +163,24 @@ int __init init_common(struct tsens_priv *priv) if (ret) return ret; if (!enabled) { - dev_err(priv->dev, "tsens device is not enabled\n"); + dev_err(dev, "tsens device is not enabled\n"); return -ENODEV; } - priv->rf[SENSOR_EN] = devm_regmap_field_alloc(priv->dev, priv->srot_map, + priv->rf[SENSOR_EN] = devm_regmap_field_alloc(dev, priv->srot_map, priv->fields[SENSOR_EN]); if (IS_ERR(priv->rf[SENSOR_EN])) return PTR_ERR(priv->rf[SENSOR_EN]); /* now alloc regmap_fields in tm_map */ for (i = 0, j = LAST_TEMP_0; i < priv->num_sensors; i++, j++) { - priv->rf[j] = devm_regmap_field_alloc(priv->dev, priv->tm_map, + priv->rf[j] = devm_regmap_field_alloc(dev, priv->tm_map, priv->fields[j]); if (IS_ERR(priv->rf[j])) return PTR_ERR(priv->rf[j]); } for (i = 0, j = VALID_0; i < priv->num_sensors; i++, j++) { - priv->rf[j] = devm_regmap_field_alloc(priv->dev, priv->tm_map, + priv->rf[j] = devm_regmap_field_alloc(dev, priv->tm_map, priv->fields[j]); if (IS_ERR(priv->rf[j])) return PTR_ERR(priv->rf[j]);