From patchwork Mon Apr 16 23:15:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10344055 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 01ED160365 for ; Mon, 16 Apr 2018 23:15:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EFF4628960 for ; Mon, 16 Apr 2018 23:15:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E448E28962; Mon, 16 Apr 2018 23:15:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 949A928960 for ; Mon, 16 Apr 2018 23:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751086AbeDPXPm (ORCPT ); Mon, 16 Apr 2018 19:15:42 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37132 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbeDPXPl (ORCPT ); Mon, 16 Apr 2018 19:15:41 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0CDA260A00; Mon, 16 Apr 2018 23:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1523920541; bh=0dVQ/50ETs//Etzalf0jbAfPwoiyFqSdDWx2QE2bJ4g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=HOxBbfEVwNV1M+s3rxAv3BBSIoFOPGE6/MzPZJU7WWPIz8qILi4+NH8Ql1FYn3Eae E+EyHMqy9og9Z78ufIawgT2R9LpcXXcv+TqwgqHlDxgsET6ATLAt7PFlhsvlbyOPCj gVP1LnX8OJFLJagJ684Z/O1oQjeHKNqH6jLOrGxs= Received: from [10.235.228.150] (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8F97F60310; Mon, 16 Apr 2018 23:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1523920540; bh=0dVQ/50ETs//Etzalf0jbAfPwoiyFqSdDWx2QE2bJ4g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ZvbPYexCZ/5xOzjlZIelMd2zsmLv4yx71qVUaflgoiJPukIiM70n/u/qzfKUkXqUt 4nsxSalpykZ58it0D4l7rH+ON09/3OJbDjDQqW0QygbPcAPxKp+BtiL9I5qrYWLKMN XMWGAkhhsFBpE/T3TlWiSycECh2KaK59AYFMS5X0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8F97F60310 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH 1/2] parisc: use the asm-generic version for writeX() To: John David Anglin , arnd@arndb.de, timur@codeaurora.org, sulrich@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "James E.J. Bottomley" , Helge Deller , Thomas Gleixner , Philippe Ombredanne , Greg Kroah-Hartman , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1523916078-23049-1-git-send-email-okaya@codeaurora.org> From: Sinan Kaya Message-ID: Date: Mon, 16 Apr 2018 19:15:37 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 4/16/2018 7:09 PM, John David Anglin wrote: > On 2018-04-16 6:01 PM, Sinan Kaya wrote: >> parisc architecture seems to be mapping writeX() and writeX_relaxed() APIs >> to __raw_writeX() API. >> >> __raw_writeX() API doesn't provide any kind of ordering guarantees. >> commit 755bd04aaf4b ("io: define stronger ordering for the default writeX() >> implementation") changed asm-generic implementation to use a more >> conservative approach towards the writeX() API. >> >> Drop the arch specific version and rely on the asm-generic version for >> parisc since parisc version doesn't seem to do anything special with these >> macros. >   HOSTLD  scripts/mod/modpost > In file included from ./arch/parisc/include/asm/hardirq.h:13:0, >                  from ./include/linux/hardirq.h:9, >                  from arch/parisc/kernel/asm-offsets.c:34: > ./include/linux/irq.h: In function 'irq_reg_writel': > ./include/linux/irq.h:1114:3: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration] >    writel(val, gc->reg_base + reg_offset); >    ^~~~~~ > ./include/linux/irq.h: In function 'irq_reg_readl': > ./include/linux/irq.h:1123:10: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration] >    return readl(gc->reg_base + reg_offset); >           ^~~~~ > cc1: some warnings being treated as errors > make[1]: *** [Kbuild:58: arch/parisc/kernel/asm-offsets.s] Error 1 > > Dave > Thanks for testing. Can you add this on top and see if it helps? --- a/arch/parisc/include/asm/io.h +++ b/arch/parisc/include/asm/io.h @@ -259,6 +259,7 @@ extern void outsl (unsigned long port, const void *src, unsigned long count); * value for either 32 or 64 bit mode */ #define F_EXTEND(x) ((unsigned long)((x) | (0xffffffff00000000ULL))) +#include #include