| Message ID | b7c07d7476697145bbd685d11a57b40d222f2c50.1597235356.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b1f0aeecd25ac11053997484510a43346297a42d |
| Headers | show |
| Series | spmi: get rid of a warning when built with W=1 | expand |
Quoting Mauro Carvalho Chehab (2020-08-12 05:29:18) > The SPMI core complaing with this warning when built with W=1: > > drivers/spmi/spmi.c: In function ‘spmi_controller_remove’: > drivers/spmi/spmi.c:548:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] > 548 | int dummy; > | ^~~~~ > > As the dummy var isn't needed, remove it. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Wed, 12 Aug 2020 14:29:18 +0200 you wrote: > The SPMI core complaing with this warning when built with W=1: > > drivers/spmi/spmi.c: In function ‘spmi_controller_remove’: > drivers/spmi/spmi.c:548:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] > 548 | int dummy; > | ^~~~~ > > [...] Here is the summary with links: - spmi: get rid of a warning when built with W=1 https://git.kernel.org/qcom/c/b1f0aeecd25a You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index c16b60f645a4..fd3ff6079b15 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -545,13 +545,10 @@ static int spmi_ctrl_remove_device(struct device *dev, void *data) */ void spmi_controller_remove(struct spmi_controller *ctrl) { - int dummy; - if (!ctrl) return; - dummy = device_for_each_child(&ctrl->dev, NULL, - spmi_ctrl_remove_device); + device_for_each_child(&ctrl->dev, NULL, spmi_ctrl_remove_device); device_del(&ctrl->dev); } EXPORT_SYMBOL_GPL(spmi_controller_remove);
The SPMI core complaing with this warning when built with W=1: drivers/spmi/spmi.c: In function ‘spmi_controller_remove’: drivers/spmi/spmi.c:548:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] 548 | int dummy; | ^~~~~ As the dummy var isn't needed, remove it. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- drivers/spmi/spmi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)