| Message ID | c33a6897f5a0803b3fde93fcf4ad652c0915db54.1637781097.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Solve the remaining issues with clang and W=1 on media | expand |
Thanks for submitting this Mauro. On Wed, 24 Nov 2021 at 20:13, Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > > Such function is currently unused, but could be needed in the > future. So, keep it, marking it as __maybe_unused, in order to > avoid a clang W=1 error. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH 00/20] at: https://lore.kernel.org/all/cover.1637781097.git.mchehab+huawei@kernel.org/ > > drivers/media/platform/qcom/camss/camss-vfe-170.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe-170.c b/drivers/media/platform/qcom/camss/camss-vfe-170.c > index 5c083d70d495..455ae1a819e6 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe-170.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe-170.c > @@ -191,7 +191,7 @@ static u32 vfe_hw_version(struct vfe_device *vfe) > return hw_version; > } > > -static inline void vfe_reg_clr(struct vfe_device *vfe, u32 reg, u32 clr_bits) > +static inline void __maybe_unused vfe_reg_clr(struct vfe_device *vfe, u32 reg, u32 clr_bits) > { > u32 bits = readl_relaxed(vfe->base + reg); > > -- > 2.33.1 > I've submitted a patch[1] for removing this function, with that patch applied, this patch is no longer needed. [1] https://lore.kernel.org/all/20211011121301.421410-1-robert.foss@linaro.org/
diff --git a/drivers/media/platform/qcom/camss/camss-vfe-170.c b/drivers/media/platform/qcom/camss/camss-vfe-170.c index 5c083d70d495..455ae1a819e6 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-170.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-170.c @@ -191,7 +191,7 @@ static u32 vfe_hw_version(struct vfe_device *vfe) return hw_version; } -static inline void vfe_reg_clr(struct vfe_device *vfe, u32 reg, u32 clr_bits) +static inline void __maybe_unused vfe_reg_clr(struct vfe_device *vfe, u32 reg, u32 clr_bits) { u32 bits = readl_relaxed(vfe->base + reg);
Such function is currently unused, but could be needed in the future. So, keep it, marking it as __maybe_unused, in order to avoid a clang W=1 error. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 00/20] at: https://lore.kernel.org/all/cover.1637781097.git.mchehab+huawei@kernel.org/ drivers/media/platform/qcom/camss/camss-vfe-170.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)