diff mbox series

[-next/-mmotm] bus/mhi: fix printk format for size_t

Message ID c4852a82-cdb9-6318-70a4-96ccb4ba5af2@infradead.org (mailing list archive)
State Accepted
Commit 3baf89abca196f6dcb7038fd5342fd6e82f3260c
Headers show
Series [-next/-mmotm] bus/mhi: fix printk format for size_t | expand

Commit Message

Randy Dunlap March 22, 2020, 4:17 a.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix printk format warning by using %z for size_t modifier:

../drivers/bus/mhi/core/boot.c: In function ‘mhi_rddm_prepare’:
../drivers/bus/mhi/core/boot.c:55:15: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘size_t {aka unsigned int}’ [-Wformat=]
  dev_dbg(dev, "Address: %p and len: 0x%lx sequence: %u\n",


Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Hemant Kumar <hemantk@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org
---
Found in mmotm, but in its linux-next.patch file.

 drivers/bus/mhi/core/boot.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Manivannan Sadhasivam March 22, 2020, 4:49 a.m. UTC | #1 
On Sat, Mar 21, 2020 at 09:17:52PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix printk format warning by using %z for size_t modifier:
> 
> ../drivers/bus/mhi/core/boot.c: In function ‘mhi_rddm_prepare’:
> ../drivers/bus/mhi/core/boot.c:55:15: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘size_t {aka unsigned int}’ [-Wformat=]
>   dev_dbg(dev, "Address: %p and len: 0x%lx sequence: %u\n",
> 
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Hemant Kumar <hemantk@codeaurora.org>
> Cc: linux-arm-msm@vger.kernel.org
> ---
> Found in mmotm, but in its linux-next.patch file.
> 
>  drivers/bus/mhi/core/boot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- mmotm-2020-0321-1517.orig/drivers/bus/mhi/core/boot.c
> +++ mmotm-2020-0321-1517/drivers/bus/mhi/core/boot.c
> @@ -52,7 +52,7 @@ void mhi_rddm_prepare(struct mhi_control
>  			    BHIE_RXVECDB_SEQNUM_BMSK, BHIE_RXVECDB_SEQNUM_SHFT,
>  			    sequence_id);
>  
> -	dev_dbg(dev, "Address: %p and len: 0x%lx sequence: %u\n",
> +	dev_dbg(dev, "Address: %p and len: 0x%zx sequence: %u\n",
>  		&mhi_buf->dma_addr, mhi_buf->len, sequence_id);
>  }
>  
>
Andrew Morton March 24, 2020, 2:24 a.m. UTC | #2 
On Sun, 22 Mar 2020 10:19:52 +0530 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:

> On Sat, Mar 21, 2020 at 09:17:52PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > Fix printk format warning by using %z for size_t modifier:
> > 
> > ../drivers/bus/mhi/core/boot.c: In function ‘mhi_rddm_prepare’:
> > ../drivers/bus/mhi/core/boot.c:55:15: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘size_t {aka unsigned int}’ [-Wformat=]
> >   dev_dbg(dev, "Address: %p and len: 0x%lx sequence: %u\n",
> > 
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks.  I guess we should tell Greg, who presently holds the offending
patch.  I shall add 

Fixes: 6fdfdd27328ce ("bus: mhi: core: Add support for downloading RDDM image du
ring panic")

and send it over.
diff mbox series

Patch

--- mmotm-2020-0321-1517.orig/drivers/bus/mhi/core/boot.c
+++ mmotm-2020-0321-1517/drivers/bus/mhi/core/boot.c
@@ -52,7 +52,7 @@  void mhi_rddm_prepare(struct mhi_control
 			    BHIE_RXVECDB_SEQNUM_BMSK, BHIE_RXVECDB_SEQNUM_SHFT,
 			    sequence_id);
 
-	dev_dbg(dev, "Address: %p and len: 0x%lx sequence: %u\n",
+	dev_dbg(dev, "Address: %p and len: 0x%zx sequence: %u\n",
 		&mhi_buf->dma_addr, mhi_buf->len, sequence_id);
 }