| Message ID | cf138f258ecbfbcc94717e4914de2f60153e5abb.1707202761.git.quic_uchalich@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | LLCC: Support for Broadcast_AND region | expand |
On 06/02/2024 08:15, Unnathi Chalicheemala wrote:
> Mapping Broadcast_AND region for LLCC in SM8450.
Why?
And why your DTS is in the middle of driver changes? Driver cannot
depend on DTS - you are now breaking all existing boards and users.
Best regards,
Krzysztof
On 2/6/2024 12:35 AM, Krzysztof Kozlowski wrote: > On 06/02/2024 08:15, Unnathi Chalicheemala wrote: >> Mapping Broadcast_AND region for LLCC in SM8450. > > Why? > > And why your DTS is in the middle of driver changes? Driver cannot > depend on DTS - you are now breaking all existing boards and users. > I was following a similar patch which has DT and driver changes in the same patchset: https://lore.kernel.org/all/20230314080443.64635-1-manivannan.sadhasivam@linaro.org/ The AND region was added in the IP block in SM8450, but was not added to the DT or driver. That is why I included both in the same patchset - if you think the DT changes should be separate I can correct it in the next version. Thanks a lot for taking the time to review Krzysztof. > > Best regards, > Krzysztof >
On Tue, 6 Feb 2024 at 22:07, Unnathi Chalicheemala <quic_uchalich@quicinc.com> wrote: > > On 2/6/2024 12:35 AM, Krzysztof Kozlowski wrote: > > On 06/02/2024 08:15, Unnathi Chalicheemala wrote: > >> Mapping Broadcast_AND region for LLCC in SM8450. > > > > Why? > > > > And why your DTS is in the middle of driver changes? Driver cannot > > depend on DTS - you are now breaking all existing boards and users. > > > > I was following a similar patch which has DT and driver changes in the > same patchset: > https://lore.kernel.org/all/20230314080443.64635-1-manivannan.sadhasivam@linaro.org/ > > The AND region was added in the IP block in SM8450, but was not added to the DT or > driver. That is why I included both in the same patchset - if you think the DT > changes should be separate I can correct it in the next version. Just move the DT changes to be the last patches in the patchset. > > Thanks a lot for taking the time to review Krzysztof. > > > > > Best regards, > > Krzysztof > > >
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 01e4dfc4babd..d2d6fae55e2a 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -4306,9 +4306,10 @@ system-cache-controller@19200000 { compatible = "qcom,sm8450-llcc"; reg = <0 0x19200000 0 0x80000>, <0 0x19600000 0 0x80000>, <0 0x19300000 0 0x80000>, <0 0x19700000 0 0x80000>, - <0 0x19a00000 0 0x80000>; + <0 0x19a00000 0 0x80000>, <0 0x19c00000 0 0x80000>; reg-names = "llcc0_base", "llcc1_base", "llcc2_base", - "llcc3_base", "llcc_broadcast_base"; + "llcc3_base", "llcc_broadcast_base", + "llcc_broadcast_and_base"; interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>; };
Mapping Broadcast_AND region for LLCC in SM8450. Signed-off-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com> --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)