| Message ID | e1984eedda04ca44a44b4972708855702f5d91e4.1547481320.git.amit.kucheria@linaro.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Andy Gross |
| Headers | show |
| Series | cpufreq: Add flag to auto-register as cooling device | expand |
Quoting Amit Kucheria (2019-01-14 08:34:55) > Minor clean-up to use BIT() and keep checkpatch happy. Clean up the > comment formatting while we're at it to make it easier to read. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
On Monday, January 14, 2019 5:34:55 PM CET Amit Kucheria wrote: > Minor clean-up to use BIT() and keep checkpatch happy. Clean up the > comment formatting while we're at it to make it easier to read. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> Can you please do this cleanup as the first patch in the series, so it doesn't depend on the other patches in it, which isn't necessary IMO? > --- > include/linux/cpufreq.h | 27 ++++++++++++++------------- > 1 file changed, 14 insertions(+), 13 deletions(-) > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > index 70ad02088825..ea303dfd5f05 100644 > --- a/include/linux/cpufreq.h > +++ b/include/linux/cpufreq.h > @@ -351,14 +351,15 @@ struct cpufreq_driver { > }; > > /* flags */ > -#define CPUFREQ_STICKY (1 << 0) /* driver isn't removed even if > - all ->init() calls failed */ > -#define CPUFREQ_CONST_LOOPS (1 << 1) /* loops_per_jiffy or other > - kernel "constants" aren't > - affected by frequency > - transitions */ > -#define CPUFREQ_PM_NO_WARN (1 << 2) /* don't warn on suspend/resume > - speed mismatches */ > + > +/* driver isn't removed even if all ->init() calls failed */ > +#define CPUFREQ_STICKY BIT(0) > + > +/* loops_per_jiffy or other kernel "constants" aren't affected by frequency transitions */ > +#define CPUFREQ_CONST_LOOPS BIT(1) > + > +/* don't warn on suspend/resume speed mismatches */ > +#define CPUFREQ_PM_NO_WARN BIT(2) > > /* > * This should be set by platforms having multiple clock-domains, i.e. > @@ -366,14 +367,14 @@ struct cpufreq_driver { > * be created in cpu/cpu<num>/cpufreq/ directory and so they can use the same > * governor with different tunables for different clusters. > */ > -#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY (1 << 3) > +#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY BIT(3) > > /* > * Driver will do POSTCHANGE notifications from outside of their ->target() > * routine and so must set cpufreq_driver->flags with this flag, so that core > * can handle them specially. > */ > -#define CPUFREQ_ASYNC_NOTIFICATION (1 << 4) > +#define CPUFREQ_ASYNC_NOTIFICATION BIT(4) > > /* > * Set by drivers which want cpufreq core to check if CPU is running at a > @@ -382,19 +383,19 @@ struct cpufreq_driver { > * from the table. And if that fails, we will stop further boot process by > * issuing a BUG_ON(). > */ > -#define CPUFREQ_NEED_INITIAL_FREQ_CHECK (1 << 5) > +#define CPUFREQ_NEED_INITIAL_FREQ_CHECK BIT(5) > > /* > * Set by drivers to disallow use of governors with "dynamic_switching" flag > * set. > */ > -#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING (1 << 6) > +#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING BIT(6) > > /* > * Set by drivers that want the core to automatically register the cpufreq > * driver as a thermal cooling device > */ > -#define CPUFREQ_AUTO_REGISTER_COOLING_DEV (1 << 7) > +#define CPUFREQ_AUTO_REGISTER_COOLING_DEV BIT(7) > > int cpufreq_register_driver(struct cpufreq_driver *driver_data); > int cpufreq_unregister_driver(struct cpufreq_driver *driver_data); >
On Thu, Jan 17, 2019 at 4:26 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > On Monday, January 14, 2019 5:34:55 PM CET Amit Kucheria wrote: > > Minor clean-up to use BIT() and keep checkpatch happy. Clean up the > > comment formatting while we're at it to make it easier to read. > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > > Can you please do this cleanup as the first patch in the series, so it > doesn't depend on the other patches in it, which isn't necessary IMO? I've sent it out separately now, unconnected to the series. Thanks. Regards, Amit > > --- > > include/linux/cpufreq.h | 27 ++++++++++++++------------- > > 1 file changed, 14 insertions(+), 13 deletions(-) > > > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h > > index 70ad02088825..ea303dfd5f05 100644 > > --- a/include/linux/cpufreq.h > > +++ b/include/linux/cpufreq.h > > @@ -351,14 +351,15 @@ struct cpufreq_driver { > > }; > > > > /* flags */ > > -#define CPUFREQ_STICKY (1 << 0) /* driver isn't removed even if > > - all ->init() calls failed */ > > -#define CPUFREQ_CONST_LOOPS (1 << 1) /* loops_per_jiffy or other > > - kernel "constants" aren't > > - affected by frequency > > - transitions */ > > -#define CPUFREQ_PM_NO_WARN (1 << 2) /* don't warn on suspend/resume > > - speed mismatches */ > > + > > +/* driver isn't removed even if all ->init() calls failed */ > > +#define CPUFREQ_STICKY BIT(0) > > + > > +/* loops_per_jiffy or other kernel "constants" aren't affected by frequency transitions */ > > +#define CPUFREQ_CONST_LOOPS BIT(1) > > + > > +/* don't warn on suspend/resume speed mismatches */ > > +#define CPUFREQ_PM_NO_WARN BIT(2) > > > > /* > > * This should be set by platforms having multiple clock-domains, i.e. > > @@ -366,14 +367,14 @@ struct cpufreq_driver { > > * be created in cpu/cpu<num>/cpufreq/ directory and so they can use the same > > * governor with different tunables for different clusters. > > */ > > -#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY (1 << 3) > > +#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY BIT(3) > > > > /* > > * Driver will do POSTCHANGE notifications from outside of their ->target() > > * routine and so must set cpufreq_driver->flags with this flag, so that core > > * can handle them specially. > > */ > > -#define CPUFREQ_ASYNC_NOTIFICATION (1 << 4) > > +#define CPUFREQ_ASYNC_NOTIFICATION BIT(4) > > > > /* > > * Set by drivers which want cpufreq core to check if CPU is running at a > > @@ -382,19 +383,19 @@ struct cpufreq_driver { > > * from the table. And if that fails, we will stop further boot process by > > * issuing a BUG_ON(). > > */ > > -#define CPUFREQ_NEED_INITIAL_FREQ_CHECK (1 << 5) > > +#define CPUFREQ_NEED_INITIAL_FREQ_CHECK BIT(5) > > > > /* > > * Set by drivers to disallow use of governors with "dynamic_switching" flag > > * set. > > */ > > -#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING (1 << 6) > > +#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING BIT(6) > > > > /* > > * Set by drivers that want the core to automatically register the cpufreq > > * driver as a thermal cooling device > > */ > > -#define CPUFREQ_AUTO_REGISTER_COOLING_DEV (1 << 7) > > +#define CPUFREQ_AUTO_REGISTER_COOLING_DEV BIT(7) > > > > int cpufreq_register_driver(struct cpufreq_driver *driver_data); > > int cpufreq_unregister_driver(struct cpufreq_driver *driver_data); > > > >
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 70ad02088825..ea303dfd5f05 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -351,14 +351,15 @@ struct cpufreq_driver { }; /* flags */ -#define CPUFREQ_STICKY (1 << 0) /* driver isn't removed even if - all ->init() calls failed */ -#define CPUFREQ_CONST_LOOPS (1 << 1) /* loops_per_jiffy or other - kernel "constants" aren't - affected by frequency - transitions */ -#define CPUFREQ_PM_NO_WARN (1 << 2) /* don't warn on suspend/resume - speed mismatches */ + +/* driver isn't removed even if all ->init() calls failed */ +#define CPUFREQ_STICKY BIT(0) + +/* loops_per_jiffy or other kernel "constants" aren't affected by frequency transitions */ +#define CPUFREQ_CONST_LOOPS BIT(1) + +/* don't warn on suspend/resume speed mismatches */ +#define CPUFREQ_PM_NO_WARN BIT(2) /* * This should be set by platforms having multiple clock-domains, i.e. @@ -366,14 +367,14 @@ struct cpufreq_driver { * be created in cpu/cpu<num>/cpufreq/ directory and so they can use the same * governor with different tunables for different clusters. */ -#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY (1 << 3) +#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY BIT(3) /* * Driver will do POSTCHANGE notifications from outside of their ->target() * routine and so must set cpufreq_driver->flags with this flag, so that core * can handle them specially. */ -#define CPUFREQ_ASYNC_NOTIFICATION (1 << 4) +#define CPUFREQ_ASYNC_NOTIFICATION BIT(4) /* * Set by drivers which want cpufreq core to check if CPU is running at a @@ -382,19 +383,19 @@ struct cpufreq_driver { * from the table. And if that fails, we will stop further boot process by * issuing a BUG_ON(). */ -#define CPUFREQ_NEED_INITIAL_FREQ_CHECK (1 << 5) +#define CPUFREQ_NEED_INITIAL_FREQ_CHECK BIT(5) /* * Set by drivers to disallow use of governors with "dynamic_switching" flag * set. */ -#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING (1 << 6) +#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING BIT(6) /* * Set by drivers that want the core to automatically register the cpufreq * driver as a thermal cooling device */ -#define CPUFREQ_AUTO_REGISTER_COOLING_DEV (1 << 7) +#define CPUFREQ_AUTO_REGISTER_COOLING_DEV BIT(7) int cpufreq_register_driver(struct cpufreq_driver *driver_data); int cpufreq_unregister_driver(struct cpufreq_driver *driver_data);
Minor clean-up to use BIT() and keep checkpatch happy. Clean up the comment formatting while we're at it to make it easier to read. Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- include/linux/cpufreq.h | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-)