| Message ID | eb92fcfb-6181-1f9d-2601-61e5231bd892@web.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: qcom: smp2p: Delete an error message in qcom_smp2p_probe() | expand |
On Sun 05 Apr 09:12 PDT 2020, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 5 Apr 2020 18:08:13 +0200 > > The function “platform_get_irq” can log an error already. > Thus omit a redundant message for the exception handling in the > calling function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Thanks Markus, picked up for 5.8. Regards, Bjorn > --- > drivers/soc/qcom/smp2p.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > index c7300d54e444..07183d731d74 100644 > --- a/drivers/soc/qcom/smp2p.c > +++ b/drivers/soc/qcom/smp2p.c > @@ -474,10 +474,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev) > goto report_read_failure; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "unable to acquire smp2p interrupt\n"); > + if (irq < 0) > return irq; > - } > > smp2p->mbox_client.dev = &pdev->dev; > smp2p->mbox_client.knows_txdone = true; > -- > 2.26.0 >
diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c index c7300d54e444..07183d731d74 100644 --- a/drivers/soc/qcom/smp2p.c +++ b/drivers/soc/qcom/smp2p.c @@ -474,10 +474,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev) goto report_read_failure; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "unable to acquire smp2p interrupt\n"); + if (irq < 0) return irq; - } smp2p->mbox_client.dev = &pdev->dev; smp2p->mbox_client.knows_txdone = true;