mbox series

[V5,0/3] lightnvm: pblk: take write semaphore on metadata

Message ID 1536665091-12641-1-git-send-email-javier@cnexlabs.com (mailing list archive)
Headers show
Series lightnvm: pblk: take write semaphore on metadata | expand

Message

Javier González Sept. 11, 2018, 11:24 a.m. UTC
# Changes since V4:
 - Rebase on top of Matias' core
 - Reorder patches to avoid in-patchset changes

# Changes since V3:
 - Encapsulate rqd dma allocations to reduce code replication (by Matias)

# Changes since V2:
 - Split the original patch between the metadata refactoring and the
   semaphore logic. This simplifies the write path, where the semaphore
   is taken.

# Changes singe V1:
    - Fix double I/O on the read path (by Matias)
    - Improve commit message (by Jens)

This patchset refactors the metadata separate write and read paths,
which simplifies how the semaphore is taken for writes.

Thanks,
Javier

Javier González (3):
  lightnvm: encapsule rqd dma allocations
  lightnvm: pblk: refactor metadata paths
  lightnvm: pblk: take write semaphore on metadata

 drivers/lightnvm/pblk-core.c     | 376 ++++++++++++++++++++-------------------
 drivers/lightnvm/pblk-gc.c       |   2 +-
 drivers/lightnvm/pblk-read.c     |  31 ++--
 drivers/lightnvm/pblk-recovery.c |  34 ++--
 drivers/lightnvm/pblk-write.c    |  15 +-
 drivers/lightnvm/pblk.h          |   7 +-
 6 files changed, 222 insertions(+), 243 deletions(-)

Comments

Matias Bjorling Sept. 17, 2018, 8:11 a.m. UTC | #1
On 09/11/2018 01:24 PM, Javier González wrote:
> # Changes since V4:
>   - Rebase on top of Matias' core
>   - Reorder patches to avoid in-patchset changes
> 
> # Changes since V3:
>   - Encapsulate rqd dma allocations to reduce code replication (by Matias)
> 
> # Changes since V2:
>   - Split the original patch between the metadata refactoring and the
>     semaphore logic. This simplifies the write path, where the semaphore
>     is taken.
> 
> # Changes singe V1:
>      - Fix double I/O on the read path (by Matias)
>      - Improve commit message (by Jens)
> 
> This patchset refactors the metadata separate write and read paths,
> which simplifies how the semaphore is taken for writes.
> 
> Thanks,
> Javier
> 
> Javier González (3):
>    lightnvm: encapsule rqd dma allocations
>    lightnvm: pblk: refactor metadata paths
>    lightnvm: pblk: take write semaphore on metadata
> 
>   drivers/lightnvm/pblk-core.c     | 376 ++++++++++++++++++++-------------------
>   drivers/lightnvm/pblk-gc.c       |   2 +-
>   drivers/lightnvm/pblk-read.c     |  31 ++--
>   drivers/lightnvm/pblk-recovery.c |  34 ++--
>   drivers/lightnvm/pblk-write.c    |  15 +-
>   drivers/lightnvm/pblk.h          |   7 +-
>   6 files changed, 222 insertions(+), 243 deletions(-)
> 

Thanks. Applied for 4.20. I've renamed the first patch to "lightnvm: 
pblk: encapsulate rqd dma allocations".
Javier Gonzalez Sept. 17, 2018, 10:11 a.m. UTC | #2
> On 17 Sep 2018, at 10.11, Matias Bjørling <mb@lightnvm.io> wrote:
> 
> On 09/11/2018 01:24 PM, Javier González wrote:
>> # Changes since V4:
>>  - Rebase on top of Matias' core
>>  - Reorder patches to avoid in-patchset changes
>> # Changes since V3:
>>  - Encapsulate rqd dma allocations to reduce code replication (by Matias)
>> # Changes since V2:
>>  - Split the original patch between the metadata refactoring and the
>>    semaphore logic. This simplifies the write path, where the semaphore
>>    is taken.
>> # Changes singe V1:
>>     - Fix double I/O on the read path (by Matias)
>>     - Improve commit message (by Jens)
>> This patchset refactors the metadata separate write and read paths,
>> which simplifies how the semaphore is taken for writes.
>> Thanks,
>> Javier
>> Javier González (3):
>>   lightnvm: encapsule rqd dma allocations
>>   lightnvm: pblk: refactor metadata paths
>>   lightnvm: pblk: take write semaphore on metadata
>>  drivers/lightnvm/pblk-core.c     | 376 ++++++++++++++++++++-------------------
>>  drivers/lightnvm/pblk-gc.c       |   2 +-
>>  drivers/lightnvm/pblk-read.c     |  31 ++--
>>  drivers/lightnvm/pblk-recovery.c |  34 ++--
>>  drivers/lightnvm/pblk-write.c    |  15 +-
>>  drivers/lightnvm/pblk.h          |   7 +-
>>  6 files changed, 222 insertions(+), 243 deletions(-)
> 
> Thanks. Applied for 4.20. I've renamed the first patch to "lightnvm: pblk: encapsulate rqd dma allocations".

Sounds good. Thanks!

Javier