mbox series

[v7,0/2] Amiga RDB partition support fixes

Message ID 1539570747-19906-1-git-send-email-schmitzmic@gmail.com (mailing list archive)
Headers show
Series Amiga RDB partition support fixes | expand

Message

Michael Schmitz Oct. 15, 2018, 2:32 a.m. UTC 
(hopefully) final version of the Amiga RDB partition table patch follows.
 
I've split off the part fixing the incorrect use of signed int
for partition start address and size as separate patch. It does fix the
bug that Martin Steigerwald reported six years ago for a 2 TB disk.
I have tested this patch with the identical RDB partition data that
Martin saw the bug with. I have incorporated Andreas' feedback on proper
use of casts to avoid integer overflow in this version.

The simple fix still leaves ample room for overflows in calculating start
address and size of a RDB partition, though such overflows should only be 
seen in rather unusual cases. To address these potential overflows, checks
are added in the second patch of this series. Comments by Geert have been   
addressed in full. 

Both patches now reviewed by Geert - Reviewed-by tags added. 

Cheers,

        Michael

Comments

Michael Schmitz Jan. 31, 2019, 12:40 a.m. UTC | #1 
All,

is there anything further I could do to speed up acceptance of these 
patches?

Cheers,

     Michael


On 15/10/18 3:32 PM, Michael Schmitz wrote:
> (hopefully) final version of the Amiga RDB partition table patch follows.
>   
> I've split off the part fixing the incorrect use of signed int
> for partition start address and size as separate patch. It does fix the
> bug that Martin Steigerwald reported six years ago for a 2 TB disk.
> I have tested this patch with the identical RDB partition data that
> Martin saw the bug with. I have incorporated Andreas' feedback on proper
> use of casts to avoid integer overflow in this version.
>
> The simple fix still leaves ample room for overflows in calculating start
> address and size of a RDB partition, though such overflows should only be
> seen in rather unusual cases. To address these potential overflows, checks
> are added in the second patch of this series. Comments by Geert have been
> addressed in full.
>
> Both patches now reviewed by Geert - Reviewed-by tags added.
>
> Cheers,
>
>          Michael
>