mbox series

[00/13] lightnvm: bugfixes and improvements

Message ID 20190227171442.11853-1-igor.j.konopko@intel.com (mailing list archive)
Headers show
Series lightnvm: bugfixes and improvements | expand

Message

Igor Konopko Feb. 27, 2019, 5:14 p.m. UTC
This series provides a group of the bugfixes
or improvements for lightnvm and pblk device.

Most of the patches are rather simple and covers
some corner cases scenario, but we were able to hit
most of them in some scenarios. Few others close some
existing gaps which we were able to found.

Fedback is appreciated.

Igor Konopko (13):
  lightnvm: pblk: Line reference fix in GC
  lightnvm: pblk: Gracefully handle GC data malloc fail
  lightnvm: pblk: Fix put line back behaviour
  lightnvm: pblk: Rollback in gc read
  lightnvm: pblk: Count all read errors in stats
  lightnvm: pblk: Ensure that erase is chunk aligned
  lightnvm: pblk: Cleanly fail when there is not enough memory
  lightnvm: pblk: Set proper read stutus in bio
  lightnvm: pblk: Kick writer for flush requests
  lightnvm: pblk: Reduce L2P DRAM footprint
  lightnvm: pblk: Remove unused smeta_ssec field
  lightnvm: pblk: close opened chunks
  lightnvm: Inherit mdts from the parent nvme device

 drivers/lightnvm/core.c          |   9 ++-
 drivers/lightnvm/pblk-core.c     | 128 +++++++++++++++++++++++++++++--
 drivers/lightnvm/pblk-gc.c       |  47 +++++++-----
 drivers/lightnvm/pblk-init.c     |  30 ++++++--
 drivers/lightnvm/pblk-map.c      |   2 +
 drivers/lightnvm/pblk-read.c     |  13 ++--
 drivers/lightnvm/pblk-recovery.c |   2 +-
 drivers/lightnvm/pblk.h          |   4 +-
 drivers/nvme/host/lightnvm.c     |   1 +
 include/linux/lightnvm.h         |   1 +
 10 files changed, 193 insertions(+), 44 deletions(-)

Comments

Matias Bjorling Feb. 28, 2019, 4:36 p.m. UTC | #1
On 2/27/19 6:14 PM, Igor Konopko wrote:
> This series provides a group of the bugfixes
> or improvements for lightnvm and pblk device.
> 
> Most of the patches are rather simple and covers
> some corner cases scenario, but we were able to hit
> most of them in some scenarios. Few others close some
> existing gaps which we were able to found.
> 
> Fedback is appreciated.
> 
> Igor Konopko (13):
>    lightnvm: pblk: Line reference fix in GC
>    lightnvm: pblk: Gracefully handle GC data malloc fail
>    lightnvm: pblk: Fix put line back behaviour
>    lightnvm: pblk: Rollback in gc read
>    lightnvm: pblk: Count all read errors in stats
>    lightnvm: pblk: Ensure that erase is chunk aligned
>    lightnvm: pblk: Cleanly fail when there is not enough memory
>    lightnvm: pblk: Set proper read stutus in bio
>    lightnvm: pblk: Kick writer for flush requests
>    lightnvm: pblk: Reduce L2P DRAM footprint
>    lightnvm: pblk: Remove unused smeta_ssec field
>    lightnvm: pblk: close opened chunks
>    lightnvm: Inherit mdts from the parent nvme device
> 
>   drivers/lightnvm/core.c          |   9 ++-
>   drivers/lightnvm/pblk-core.c     | 128 +++++++++++++++++++++++++++++--
>   drivers/lightnvm/pblk-gc.c       |  47 +++++++-----
>   drivers/lightnvm/pblk-init.c     |  30 ++++++--
>   drivers/lightnvm/pblk-map.c      |   2 +
>   drivers/lightnvm/pblk-read.c     |  13 ++--
>   drivers/lightnvm/pblk-recovery.c |   2 +-
>   drivers/lightnvm/pblk.h          |   4 +-
>   drivers/nvme/host/lightnvm.c     |   1 +
>   include/linux/lightnvm.h         |   1 +
>   10 files changed, 193 insertions(+), 44 deletions(-)
> 

Thanks Igor. I'll give Hans et. al. a couple of days to digest the 
changes.
Javier González Feb. 28, 2019, 5:15 p.m. UTC | #2
> On 28 Feb 2019, at 11.36, Matias Bjørling <mb@lightnvm.io> wrote:
> 
> On 2/27/19 6:14 PM, Igor Konopko wrote:
>> This series provides a group of the bugfixes
>> or improvements for lightnvm and pblk device.
>> Most of the patches are rather simple and covers
>> some corner cases scenario, but we were able to hit
>> most of them in some scenarios. Few others close some
>> existing gaps which we were able to found.
>> Fedback is appreciated.
>> Igor Konopko (13):
>>   lightnvm: pblk: Line reference fix in GC
>>   lightnvm: pblk: Gracefully handle GC data malloc fail
>>   lightnvm: pblk: Fix put line back behaviour
>>   lightnvm: pblk: Rollback in gc read
>>   lightnvm: pblk: Count all read errors in stats
>>   lightnvm: pblk: Ensure that erase is chunk aligned
>>   lightnvm: pblk: Cleanly fail when there is not enough memory
>>   lightnvm: pblk: Set proper read stutus in bio
>>   lightnvm: pblk: Kick writer for flush requests
>>   lightnvm: pblk: Reduce L2P DRAM footprint
>>   lightnvm: pblk: Remove unused smeta_ssec field
>>   lightnvm: pblk: close opened chunks
>>   lightnvm: Inherit mdts from the parent nvme device
>>  drivers/lightnvm/core.c          |   9 ++-
>>  drivers/lightnvm/pblk-core.c     | 128 +++++++++++++++++++++++++++++--
>>  drivers/lightnvm/pblk-gc.c       |  47 +++++++-----
>>  drivers/lightnvm/pblk-init.c     |  30 ++++++--
>>  drivers/lightnvm/pblk-map.c      |   2 +
>>  drivers/lightnvm/pblk-read.c     |  13 ++--
>>  drivers/lightnvm/pblk-recovery.c |   2 +-
>>  drivers/lightnvm/pblk.h          |   4 +-
>>  drivers/nvme/host/lightnvm.c     |   1 +
>>  include/linux/lightnvm.h         |   1 +
>>  10 files changed, 193 insertions(+), 44 deletions(-)
> 
> Thanks Igor. I'll give Hans et. al. a couple of days to digest the changes.

If it is that difficult to spell Javier you can look at the pblk copyright…

I’ll review the patches next week.

Javier
Hans Holmberg March 1, 2019, 10:23 a.m. UTC | #3
Good stuff Igor!

The jetlag from vault is wearing off now, so I'll start looking at the
patches today.

Thanks,
Hans

On Thu, Feb 28, 2019 at 11:36 AM Matias Bjørling <mb@lightnvm.io> wrote:
>
> On 2/27/19 6:14 PM, Igor Konopko wrote:
> > This series provides a group of the bugfixes
> > or improvements for lightnvm and pblk device.
> >
> > Most of the patches are rather simple and covers
> > some corner cases scenario, but we were able to hit
> > most of them in some scenarios. Few others close some
> > existing gaps which we were able to found.
> >
> > Fedback is appreciated.
> >
> > Igor Konopko (13):
> >    lightnvm: pblk: Line reference fix in GC
> >    lightnvm: pblk: Gracefully handle GC data malloc fail
> >    lightnvm: pblk: Fix put line back behaviour
> >    lightnvm: pblk: Rollback in gc read
> >    lightnvm: pblk: Count all read errors in stats
> >    lightnvm: pblk: Ensure that erase is chunk aligned
> >    lightnvm: pblk: Cleanly fail when there is not enough memory
> >    lightnvm: pblk: Set proper read stutus in bio
> >    lightnvm: pblk: Kick writer for flush requests
> >    lightnvm: pblk: Reduce L2P DRAM footprint
> >    lightnvm: pblk: Remove unused smeta_ssec field
> >    lightnvm: pblk: close opened chunks
> >    lightnvm: Inherit mdts from the parent nvme device
> >
> >   drivers/lightnvm/core.c          |   9 ++-
> >   drivers/lightnvm/pblk-core.c     | 128 +++++++++++++++++++++++++++++--
> >   drivers/lightnvm/pblk-gc.c       |  47 +++++++-----
> >   drivers/lightnvm/pblk-init.c     |  30 ++++++--
> >   drivers/lightnvm/pblk-map.c      |   2 +
> >   drivers/lightnvm/pblk-read.c     |  13 ++--
> >   drivers/lightnvm/pblk-recovery.c |   2 +-
> >   drivers/lightnvm/pblk.h          |   4 +-
> >   drivers/nvme/host/lightnvm.c     |   1 +
> >   include/linux/lightnvm.h         |   1 +
> >   10 files changed, 193 insertions(+), 44 deletions(-)
> >
>
> Thanks Igor. I'll give Hans et. al. a couple of days to digest the
> changes.
>