[V5,0/9] blk-mq: fix races related with freeing queue

Message

Ming Lei April 12, 2019, 3:30 a.m. UTC

Hi,

Since 45a9c9d909b2 ("blk-mq: Fix a use-after-free"), run queue isn't
allowed during cleanup queue even though queue refcount is held.

This change has caused lots of kernel oops triggered in run queue path,
turns out it isn't easy to fix them all.

So move freeing of hw queue resources into hctx's release handler, then
the above issue is fixed. Meantime, this way is safe given freeing hw
queue resource doesn't require tags.

V3 covers more races.

V5:
	- refactor blk_mq_alloc_and_init_hctx()
	- fix race related updating nr_hw_queues by always freeing hctx
	  after request queue is released

V4:
	- add patch for fixing potential use-after-free in blk_mq_update_nr_hw_queues
	- fix comment in the last patch

V3:
	- cancel q->requeue_work in queue's release handler
	- cancel hctx->run_work in hctx's release handler
	- add patch 1 for fixing race in plug code path
	- the last patch is added for avoiding to grab SCSI's refcont
	in IO path

V2:
	- moving freeing hw queue resources into hctx's release handler



Ming Lei (9):
  blk-mq: grab .q_usage_counter when queuing request from plug code path
  blk-mq: move cancel of requeue_work into blk_mq_release
  blk-mq: free hw queue's resource in hctx's release handler
  blk-mq: move all hctx alloction & initialization into
    __blk_mq_alloc_and_init_hctx
  blk-mq: split blk_mq_alloc_and_init_hctx into two parts
  blk-mq: always free hctx after request queue is freed
  blk-mq: move cancel of hctx->run_work into blk_mq_hw_sysfs_release
  block: don't drain in-progress dispatch in blk_cleanup_queue()
  SCSI: don't hold device refcount in IO path

 block/blk-core.c        |  23 +-----
 block/blk-mq-sysfs.c    |   8 +++
 block/blk-mq.c          | 188 ++++++++++++++++++++++++++++--------------------
 block/blk-mq.h          |   2 +-
 drivers/scsi/scsi_lib.c |  28 +-------
 include/linux/blk-mq.h  |   2 +
 include/linux/blkdev.h  |   7 ++
 7 files changed, 132 insertions(+), 126 deletions(-)

Cc: Dongli Zhang <[e-mail]>
Cc: James Smart <[e-mail]>
Cc: Bart Van Assche <[e-mail]>
Cc: [e-mail],
Cc: Martin K . Petersen <[e-mail]>,
Cc: Christoph Hellwig <[e-mail]>,
Cc: James E . J . Bottomley <[e-mail]>,
Cc: jianchao wang <[e-mail]>