mbox series

[0/1] blk-mq error handling memory leak

Message ID 20190419203544.11725-1-Jes.Sorensen@gmail.com (mailing list archive)
Headers show
Series blk-mq error handling memory leak | expand

Message

Jes Sorensen April 19, 2019, 8:35 p.m. UTC 
From: Jes Sorensen <jsorensen@fb.com>

Hi,

Digging through this, I don't see the callback data getting freed in
case of errors in blk_mq_init_allocated_queue() unless I am missing
some obscure path that cleans it up later?

Cheers,
Jes

Jes Sorensen (1):
  blk-mq: Fix memory leak in error handling

 block/blk-mq.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Jes Sorensen May 29, 2019, 8:16 p.m. UTC | #1 
On 4/19/19 4:35 PM, Jes Sorensen wrote:
> From: Jes Sorensen <jsorensen@fb.com>
> 
> Hi,
> 
> Digging through this, I don't see the callback data getting freed in
> case of errors in blk_mq_init_allocated_queue() unless I am missing
> some obscure path that cleans it up later?

Ping!

Any reason not to apply this?

Thanks,
Jes

> Cheers,
> Jes
> 
> Jes Sorensen (1):
>   blk-mq: Fix memory leak in error handling
> 
>  block/blk-mq.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>