[0/2] Remove blk_mq_sched_started_request function

Message

Marcos Paulo de Souza July 23, 2019, 2:14 a.m. UTC

While inspecting the queue_rq calling sites, I verified that
blk_mq_start_request calls blk_mq_sched_started_request, and this function
checks if the elevator of the current request implements the started_request,
but currently none of the available IO schedulers do.

So, let's remove blk_mq_sched_started_request along with started_request, which
is member of the elevator_mq_ops struct.

Marcos Paulo de Souza (2):
  block: blk-mq: Remove blk_mq_sched_started_request function
  include: elevator.h: Remove started_request from elevator_mq_ops

 block/blk-mq-sched.h     | 9 ---------
 block/blk-mq.c           | 2 --
 include/linux/elevator.h | 1 -
 3 files changed, 12 deletions(-)

Comments

Jens Axboe July 23, 2019, 2:17 a.m. UTC | #1

On 7/22/19 8:14 PM, Marcos Paulo de Souza wrote:
> While inspecting the queue_rq calling sites, I verified that
> blk_mq_start_request calls blk_mq_sched_started_request, and this function
> checks if the elevator of the current request implements the started_request,
> but currently none of the available IO schedulers do.
> 
> So, let's remove blk_mq_sched_started_request along with started_request, which
> is member of the elevator_mq_ops struct.

Looks fine to me as it's unused, but please fold the two patches. Makes no
sense to split that into two separate patches.