[v3,0/3] null_blk: fixes around nr_devices and log improvements

Message

André Almeida Sept. 16, 2019, 2:07 p.m. UTC

Hello,

This patch series address feedback for a previous patch series sent by
me "docs: block: null_blk: enhance document style"[1].

First patch removes a restriction that prevents null_blk to load with
(nr_devices == 0). This restriction breaks applications, so it's a bug. I
have tested it running the kernel with `null_blk.nr_devices=0`.

In the previous series I have changed the type of var nr_devices, but I
forgot to change the type at module_param(). The second patch fix that.

The third patch uses a cleaver approach to make log messages consistent
using pr_fmt and the last one add a note on how to do that at the
coding style documentation.

Thanks,
	André

Changes since v2:
- Add "Reviewed-by: Chaitanya Kulkarni" (thanks!)
- Drop "[v2,4/4] coding-style: add explanation about pr_fmt macro"
from this series

Changes since v1:
 - Add "Fixes" tag at [2/4]
 - No more headers reordering at [3/4]
 - Use #undef pr_fmt and KBUILD_MODNAME at [3/4] and [4/4]
 - Replace "printk.h" for "kernel.h" at [4/4]

 More details are provided at each patch changelog

[1] https://patchwork.kernel.org/project/linux-block/list/?series=172853

André Almeida (3):
  null_blk: do not fail the module load with zero devices
  null_blk: match the type of parameter nr_devices
  null_blk: format pr_* logs with pr_fmt

 drivers/block/null_blk.h       |  5 ++++-
 drivers/block/null_blk_main.c  | 22 +++++++++-------------
 drivers/block/null_blk_zoned.c |  4 ++--
 3 files changed, 15 insertions(+), 16 deletions(-)

Comments

Jens Axboe Sept. 16, 2019, 2:55 p.m. UTC | #1

On 9/16/19 8:07 AM, André Almeida wrote:
> Hello,
> 
> This patch series address feedback for a previous patch series sent by
> me "docs: block: null_blk: enhance document style"[1].
> 
> First patch removes a restriction that prevents null_blk to load with
> (nr_devices == 0). This restriction breaks applications, so it's a bug. I
> have tested it running the kernel with `null_blk.nr_devices=0`.
> 
> In the previous series I have changed the type of var nr_devices, but I
> forgot to change the type at module_param(). The second patch fix that.
> 
> The third patch uses a cleaver approach to make log messages consistent
> using pr_fmt and the last one add a note on how to do that at the
> coding style documentation.

Applied, thanks.