From patchwork Tue Nov 26 09:14:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 11261643 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A5F721393 for ; Tue, 26 Nov 2019 09:14:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90AC5207DD for ; Tue, 26 Nov 2019 09:14:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727472AbfKZJOZ (ORCPT ); Tue, 26 Nov 2019 04:14:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:41604 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727464AbfKZJOZ (ORCPT ); Tue, 26 Nov 2019 04:14:25 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8F17FB9EC; Tue, 26 Nov 2019 09:14:23 +0000 (UTC) From: Hannes Reinecke To: "Martin K. Petersen" Cc: Christoph Hellwig , James Bottomley , Ming Lei , Bart van Assche , John Garry , linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, Hannes Reinecke Subject: [PATCH RFC v3 0/8] blk-mq/scsi: Provide hostwide shared tags for SCSI HBAs Date: Tue, 26 Nov 2019 10:14:08 +0100 Message-Id: <20191126091416.20052-1-hare@suse.de> X-Mailer: git-send-email 2.16.4 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi all, here now is an updated version of the v2 patchset from John Garry, including the suggestions and reviews from the mailing list. John, apologies for hijacking your work :-) The main diffence is that I've changed the bitmaps to be allocated separately in all cases, and just set the pointer to the shared bitmap for the hostwide tags case. I've also modified smartpqi and hpsa to take advantage of host_tags. I did audit the iterators, and I _think_ they do the correct thing even in the shared bitmap case. But then I might have overlooked things, so feedback and reviews are welcome. The one thing I'm not happy with is the debugfs interface; for shared bitmaps all will be displaying essentially the same information, which could be moved to a top-level directory. But that would change the layout and I'm not sure if that buys us anything. Differences to v2: - Drop embedded tag bitmaps - Do not share scheduling tags - Add patches for hpsa and smartpqi Differences to v1: - Use a shared sbitmap, and not a separate shared tags (a big change!) - Drop request.shared_tag - Add RB tags Hannes Reinecke (4): blk-mq: Use a pointer for sbitmap scsi: Add template flag 'host_tagset' smartpqi: enable host tagset hpsa: switch to using blk-mq John Garry (3): blk-mq: Remove some unused function arguments blk-mq: Facilitate a shared sbitmap per tagset scsi: hisi_sas: Switch v3 hw to MQ Ming Lei (1): blk-mq: rename BLK_MQ_F_TAG_SHARED as BLK_MQ_F_TAG_QUEUE_SHARED block/bfq-iosched.c | 4 +- block/blk-mq-debugfs.c | 10 ++-- block/blk-mq-sched.c | 8 ++- block/blk-mq-tag.c | 104 ++++++++++++++++++++++----------- block/blk-mq-tag.h | 18 +++--- block/blk-mq.c | 80 ++++++++++++++++--------- block/blk-mq.h | 9 ++- block/kyber-iosched.c | 4 +- drivers/scsi/hisi_sas/hisi_sas.h | 3 +- drivers/scsi/hisi_sas/hisi_sas_main.c | 36 ++++++------ drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 86 +++++++++++---------------- drivers/scsi/hpsa.c | 44 +++----------- drivers/scsi/hpsa.h | 1 - drivers/scsi/scsi_lib.c | 2 + drivers/scsi/smartpqi/smartpqi_init.c | 38 ++++++++---- include/linux/blk-mq.h | 9 ++- include/scsi/scsi_host.h | 3 + 17 files changed, 260 insertions(+), 199 deletions(-)