| Message ID | 20200213123728.61216-1-pasic@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | virtio-blk: improve handling of DMA mapping failures | expand |
On Thu, Feb 13, 2020 at 01:37:26PM +0100, Halil Pasic wrote: > Two patches are handling new edge cases introduced by doing DMA mappings > (which can fail) in virtio core. > > I stumbled upon this while stress testing I/O for Protected Virtual > Machines. I deliberately chose a tiny swiotlb size and have generated > load with fio. With more than one virtio-blk disk in use I experienced > hangs. > > The goal of this series is to fix those hangs. > > Halil Pasic (2): > virtio-blk: fix hw_queue stopped on arbitrary error > virtio-blk: improve virtqueue error to BLK_STS > > drivers/block/virtio_blk.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > > base-commit: 39bed42de2e7d74686a2d5a45638d6a5d7e7d473 > -- > 2.17.1 > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On Thu, 13 Feb 2020 13:37:26 +0100 Halil Pasic <pasic@linux.ibm.com> wrote: > Two patches are handling new edge cases introduced by doing DMA mappings > (which can fail) in virtio core. > > I stumbled upon this while stress testing I/O for Protected Virtual > Machines. I deliberately chose a tiny swiotlb size and have generated > load with fio. With more than one virtio-blk disk in use I experienced > hangs. > > The goal of this series is to fix those hangs. > > Halil Pasic (2): > virtio-blk: fix hw_queue stopped on arbitrary error > virtio-blk: improve virtqueue error to BLK_STS > > drivers/block/virtio_blk.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > > base-commit: 39bed42de2e7d74686a2d5a45638d6a5d7e7d473 ping Hi Michael, hi Jason, I got some favorable reviews for this, but AFAIK I got nothing form the maintainers yet. Is some of you going to pick these? Regards, Halil
On Tue, Mar 03, 2020 at 03:12:52PM +0100, Halil Pasic wrote: > On Thu, 13 Feb 2020 13:37:26 +0100 > Halil Pasic <pasic@linux.ibm.com> wrote: > > > Two patches are handling new edge cases introduced by doing DMA mappings > > (which can fail) in virtio core. > > > > I stumbled upon this while stress testing I/O for Protected Virtual > > Machines. I deliberately chose a tiny swiotlb size and have generated > > load with fio. With more than one virtio-blk disk in use I experienced > > hangs. > > > > The goal of this series is to fix those hangs. > > > > Halil Pasic (2): > > virtio-blk: fix hw_queue stopped on arbitrary error > > virtio-blk: improve virtqueue error to BLK_STS > > > > drivers/block/virtio_blk.c | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > > > base-commit: 39bed42de2e7d74686a2d5a45638d6a5d7e7d473 > > ping > > Hi Michael, hi Jason, > > I got some favorable reviews for this, but AFAIK I got nothing form the > maintainers yet. > > Is some of you going to pick these? > > Regards, > Halil I've queued this, thanks!
On Tue, 3 Mar 2020 09:49:21 -0500 "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Tue, Mar 03, 2020 at 03:12:52PM +0100, Halil Pasic wrote: > > On Thu, 13 Feb 2020 13:37:26 +0100 > > Halil Pasic <pasic@linux.ibm.com> wrote: > > > > > Two patches are handling new edge cases introduced by doing DMA mappings > > > (which can fail) in virtio core. > > > > > > I stumbled upon this while stress testing I/O for Protected Virtual > > > Machines. I deliberately chose a tiny swiotlb size and have generated > > > load with fio. With more than one virtio-blk disk in use I experienced > > > hangs. > > > > > > The goal of this series is to fix those hangs. > > > > > > Halil Pasic (2): > > > virtio-blk: fix hw_queue stopped on arbitrary error > > > virtio-blk: improve virtqueue error to BLK_STS > > > > > > drivers/block/virtio_blk.c | 17 ++++++++++++----- > > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > > > > > > base-commit: 39bed42de2e7d74686a2d5a45638d6a5d7e7d473 > > > > ping > > > > Hi Michael, hi Jason, > > > > I got some favorable reviews for this, but AFAIK I got nothing form the > > maintainers yet. > > > > Is some of you going to pick these? > > > > Regards, > > Halil > > I've queued this, thanks! > Thank you!