| Message ID | 20201016142811.1262214-1-ming.lei@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | blk-mq/nvme-tcp: fix timed out related races | expand |
Thanks Ming, feel free to add: Tested-by: Yi Zhang <yi.zhang@redhat.com> For the timeout issue, I've filed below issue to track it, thanks. https://bugzilla.kernel.org/show_bug.cgi?id=209763 Best Regards, Yi Zhang ----- Original Message ----- From: "Ming Lei" <ming.lei@redhat.com> To: "Jens Axboe" <axboe@kernel.dk>, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, "Christoph Hellwig" <hch@lst.de>, "Keith Busch" <kbusch@kernel.org> Cc: "Yi Zhang" <yi.zhang@redhat.com>, "Sagi Grimberg" <sagi@grimberg.me>, "Chao Leng" <lengchao@huawei.com>, "Ming Lei" <ming.lei@redhat.com> Sent: Friday, October 16, 2020 10:28:07 PM Subject: [PATCH 0/4] blk-mq/nvme-tcp: fix timed out related races Hi, The 1st 2 patches fixes request completion related races. The 2nd 3 patches fixes/improves nvme-tcp error recovery. With the 4 patches, nvme/012 can pass on nvme-tcp in Zhang Yi's test machine. Ming Lei (4): blk-mq: check rq->state explicitly in blk_mq_tagset_count_completed_rqs blk-mq: think request as completed if it isn't IN_FLIGHT. nvme: tcp: fix race between timeout and normal completion nvme: tcp: complete non-IO requests atomically block/blk-flush.c | 2 ++ block/blk-mq-tag.c | 2 +- drivers/nvme/host/tcp.c | 76 +++++++++++++++++++++++++++++------------ include/linux/blk-mq.h | 8 ++++- 4 files changed, 65 insertions(+), 23 deletions(-) CC: Chao Leng <lengchao@huawei.com> Cc: Sagi Grimberg <sagi@grimberg.me> Cc: Yi Zhang <yi.zhang@redhat.com>
Hi, The 1st 2 patches fixes request completion related races. The 2nd 3 patches fixes/improves nvme-tcp error recovery. With the 4 patches, nvme/012 can pass on nvme-tcp in Zhang Yi's test machine. Ming Lei (4): blk-mq: check rq->state explicitly in blk_mq_tagset_count_completed_rqs blk-mq: think request as completed if it isn't IN_FLIGHT. nvme: tcp: fix race between timeout and normal completion nvme: tcp: complete non-IO requests atomically block/blk-flush.c | 2 ++ block/blk-mq-tag.c | 2 +- drivers/nvme/host/tcp.c | 76 +++++++++++++++++++++++++++++------------ include/linux/blk-mq.h | 8 ++++- 4 files changed, 65 insertions(+), 23 deletions(-) CC: Chao Leng <lengchao@huawei.com> Cc: Sagi Grimberg <sagi@grimberg.me> Cc: Yi Zhang <yi.zhang@redhat.com>