[0/9] n64: small cleanups

Message

Chaitanya Kulkarni Jan. 25, 2021, 11:32 p.m. UTC

Hi Lauri,

This cleanup series is based on the top of v11 that adds kernel coding
style fixes in the various places without changing the functionality.

Instead of sending a one big patch I've made small patches which are
easier to review, integrate, blame and revert in case of any error.

I've got the reviewed-by tag from the driver owner offline which
is added to the series.

-ck

Chaitanya Kulkarni (9):
  n64: use pr_fmt to avoid duplicate string
  n64: move module info at the end
  n64: move module param at the top
  n64: use enums for reg
  n64: use sector SECTOR_SHIFT instead 512
  n64: remove curly brackets
  n64: cosmetics changes
  n64: cleanup n64cart_probe()
  n64: store dev instance into disk private data

 drivers/block/n64cart.c | 87 ++++++++++++++++++-----------------------
 1 file changed, 38 insertions(+), 49 deletions(-)

Comments

Lauri Kasanen Jan. 26, 2021, 8 a.m. UTC | #1

On Mon, 25 Jan 2021 15:32:34 -0800
Chaitanya Kulkarni <[e-mail]> wrote:

> I've got the reviewed-by tag from the driver owner offline which
> is added to the series.

I confirm this, he sent it privately first. I approve the series.

- Lauri

Thomas Bogendoerfer Feb. 21, 2021, 10:39 p.m. UTC | #2

On Mon, Jan 25, 2021 at 03:32:34PM -0800, Chaitanya Kulkarni wrote:
> Hi Lauri,
> 
> This cleanup series is based on the top of v11 that adds kernel coding
> style fixes in the various places without changing the functionality.
> 
> Instead of sending a one big patch I've made small patches which are
> easier to review, integrate, blame and revert in case of any error.
> 
> I've got the reviewed-by tag from the driver owner offline which
> is added to the series.
> 
> -ck
> 
> Chaitanya Kulkarni (9):
>   n64: use pr_fmt to avoid duplicate string
>   n64: move module info at the end
>   n64: move module param at the top
>   n64: use enums for reg
>   n64: use sector SECTOR_SHIFT instead 512
>   n64: remove curly brackets
>   n64: cosmetics changes
>   n64: cleanup n64cart_probe()
>   n64: store dev instance into disk private data
> 
>  drivers/block/n64cart.c | 87 ++++++++++++++++++-----------------------
>  1 file changed, 38 insertions(+), 49 deletions(-)

series applied to mips-next.

Thomas.