From patchwork Thu May 20 14:13:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 12270509 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54843C433B4 for ; Thu, 20 May 2021 14:14:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37044608FE for ; Thu, 20 May 2021 14:14:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234545AbhETOPq (ORCPT ); Thu, 20 May 2021 10:15:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48932 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239729AbhETOOn (ORCPT ); Thu, 20 May 2021 10:14:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621520000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vkKoZ+CKUsYvNnISKHeZZWH2ryJwgpmqIR8PS+x2z3k=; b=WlLpepYbQzrQOOq6ZqkrJRJVH/S2WphTPDvcqaUmbqHpvkrE1TKORfJHVnVDwU5g06U04U pQsGx++DMdwH5MoJT6SZkOsiSXD+OZJalSrJZf5dz0f6TnOQQi89raO2zbW05LOflsVSGm vlJkN+8EPIDe9weGDDfmcQYe+zjBaZU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-iepZhC42MJ6ZH5r6tVwZig-1; Thu, 20 May 2021 10:13:19 -0400 X-MC-Unique: iepZhC42MJ6ZH5r6tVwZig-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A4AB4180FD61; Thu, 20 May 2021 14:13:17 +0000 (UTC) Received: from localhost (ovpn-115-223.ams2.redhat.com [10.36.115.223]) by smtp.corp.redhat.com (Postfix) with ESMTP id 96EC51001B2C; Thu, 20 May 2021 14:13:06 +0000 (UTC) From: Stefan Hajnoczi To: virtualization@lists.linux-foundation.org Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jason Wang , Paolo Bonzini , Jens Axboe , slp@redhat.com, sgarzare@redhat.com, "Michael S. Tsirkin" , Stefan Hajnoczi Subject: [PATCH 0/3] virtio_blk: blk-mq io_poll support Date: Thu, 20 May 2021 15:13:02 +0100 Message-Id: <20210520141305.355961-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org This patch series implements blk_mq_ops->poll() so REQ_HIPRI requests can be polled. IOPS for 4k and 16k block sizes increases by 5-18% on a virtio-blk device with 4 virtqueues backed by an NVMe drive. - Benchmark: fio ioengine=pvsync2 numjobs=4 direct=1 - Guest: 4 vCPUs with one virtio-blk device (4 virtqueues) - Disk: Intel Corporation NVMe Datacenter SSD [Optane] [8086:2701] - CPU: Intel(R) Xeon(R) Silver 4214 CPU @ 2.20GHz rw bs hipri=0 hipri=1 ------------------------------ randread 4k 149,426 170,763 +14% randread 16k 118,939 134,269 +12% randread 64k 34,886 34,906 0% randread 128k 17,655 17,667 0% randwrite 4k 138,578 163,600 +18% randwrite 16k 102,089 120,950 +18% randwrite 64k 32,364 32,561 0% randwrite 128k 16,154 16,237 0% read 4k 146,032 170,620 +16% read 16k 117,097 130,437 +11% read 64k 34,834 35,037 0% read 128k 17,680 17,658 0% write 4k 134,562 151,422 +12% write 16k 101,796 107,606 +5% write 64k 32,364 32,594 0% write 128k 16,259 16,265 0% Larger block sizes do not benefit from polling as much but the improvement is worthwhile for smaller block sizes. Stefan Hajnoczi (3): virtio: add virtioqueue_more_used() virtio_blk: avoid repeating vblk->vqs[qid] virtio_blk: implement blk_mq_ops->poll() include/linux/virtio.h | 2 + drivers/block/virtio_blk.c | 126 +++++++++++++++++++++++++++++------ drivers/virtio/virtio_ring.c | 17 +++++ 3 files changed, 123 insertions(+), 22 deletions(-)