mbox series

[v5,0/2] cancel all throttled bios in del_gendisk()

Message ID 20211210083143.3181535-1-yukuai3@huawei.com (mailing list archive)
Headers show
Series cancel all throttled bios in del_gendisk() | expand

Message

Yu Kuai Dec. 10, 2021, 8:31 a.m. UTC
If del_gendisk() is done when some io are still throttled, such io
will not be handled until the throttle is done, which is not
necessary.

Changes in v2:
 - move WARN_ON_ONCE() from throtl_rb_first() to it's caller
 - merge some patches into one.

Changes in v3:
 - some code optimization in patch 1
 - hold queue lock to cancel bios in patch 2

Changes in v4:
 - delete rcu_read_lock() and rcu_read_unlock() in patch 2

Changes in v5:
 - add comment about rcu lock

Yu Kuai (2):
  blk-throtl: move WARN_ON_ONCE() from throtl_rb_first() to it's caller
  block: cancel all throttled bios in del_gendisk()

 block/blk-throttle.c | 75 ++++++++++++++++++++++++++++++++++++++++++--
 block/blk-throttle.h |  2 ++
 block/genhd.c        |  2 ++
 3 files changed, 76 insertions(+), 3 deletions(-)

Comments

Yu Kuai Dec. 18, 2021, 9:09 a.m. UTC | #1
在 2021/12/10 16:31, Yu Kuai 写道:
> If del_gendisk() is done when some io are still throttled, such io
> will not be handled until the throttle is done, which is not
> necessary.
> 
> Changes in v2:
>   - move WARN_ON_ONCE() from throtl_rb_first() to it's caller
>   - merge some patches into one.
> 
> Changes in v3:
>   - some code optimization in patch 1
>   - hold queue lock to cancel bios in patch 2
> 
> Changes in v4:
>   - delete rcu_read_lock() and rcu_read_unlock() in patch 2
> 
> Changes in v5:
>   - add comment about rcu lock
Friendly ping...
> 
> Yu Kuai (2):
>    blk-throtl: move WARN_ON_ONCE() from throtl_rb_first() to it's caller
>    block: cancel all throttled bios in del_gendisk()
> 
>   block/blk-throttle.c | 75 ++++++++++++++++++++++++++++++++++++++++++--
>   block/blk-throttle.h |  2 ++
>   block/genhd.c        |  2 ++
>   3 files changed, 76 insertions(+), 3 deletions(-)
>
Yu Kuai Jan. 7, 2022, 1:08 a.m. UTC | #2
在 2021/12/18 17:09, yukuai (C) 写道:
> 在 2021/12/10 16:31, Yu Kuai 写道:
>> If del_gendisk() is done when some io are still throttled, such io
>> will not be handled until the throttle is done, which is not
>> necessary.
>>
>> Changes in v2:
>>   - move WARN_ON_ONCE() from throtl_rb_first() to it's caller
>>   - merge some patches into one.
>>
>> Changes in v3:
>>   - some code optimization in patch 1
>>   - hold queue lock to cancel bios in patch 2
>>
>> Changes in v4:
>>   - delete rcu_read_lock() and rcu_read_unlock() in patch 2
>>
>> Changes in v5:
>>   - add comment about rcu lock
> Friendly ping...

Friendly ping ...

>>
>> Yu Kuai (2):
>>    blk-throtl: move WARN_ON_ONCE() from throtl_rb_first() to it's caller
>>    block: cancel all throttled bios in del_gendisk()
>>
>>   block/blk-throttle.c | 75 ++++++++++++++++++++++++++++++++++++++++++--
>>   block/blk-throttle.h |  2 ++
>>   block/genhd.c        |  2 ++
>>   3 files changed, 76 insertions(+), 3 deletions(-)
>>