| Message ID | 20220921095309.1481289-1-yukuai1@huaweicloud.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | blk-throttle: improve bypassing bios checkings | expand |
On Wed, 21 Sep 2022 17:53:07 +0800, Yu Kuai wrote: > From: Yu Kuai <yukuai3@huawei.com> > > Currently, "tg->has_rules" and "tg->flags & THROTL_TG_HAS_IOPS_LIMIT" > both try to bypass bios that don't need to be throttled, however, they are > a little redundant and both not perfect: > > 1) "tg->has_rules" only distinguish read and write, but not iops and bps > limit. > 2) "tg->flags & THROTL_TG_HAS_IOPS_LIMIT" only check if iops limit > exist, read and write is not distinguished, and bps limit is not > checked. > > [...] Applied, thanks! [1/2] blk-throttle: remove THROTL_TG_HAS_IOPS_LIMIT commit: 85496749904016f36b69332f73a1cf3ecfee828f [2/2] blk-throttle: improve bypassing bios checkings commit: 81c7a63abc7c0be572b4f853e913ce93a34f6e1b Best regards,
From: Yu Kuai <yukuai3@huawei.com> Currently, "tg->has_rules" and "tg->flags & THROTL_TG_HAS_IOPS_LIMIT" both try to bypass bios that don't need to be throttled, however, they are a little redundant and both not perfect: 1) "tg->has_rules" only distinguish read and write, but not iops and bps limit. 2) "tg->flags & THROTL_TG_HAS_IOPS_LIMIT" only check if iops limit exist, read and write is not distinguished, and bps limit is not checked. With this patchset, biowon't be bypassedd if: 1) Bio is read/write, and corresponding read/write iops limit exist. 2) If corresponding iops limit doesn't exist, corresponding bps limit exist and bio is not throttled before. Yu Kuai (2): blk-throttle: remove THROTL_TG_HAS_IOPS_LIMIT blk-throttle: improve bypassing bios checkings block/blk-throttle.c | 21 +++++++-------------- block/blk-throttle.h | 28 +++++++++++++++++++--------- 2 files changed, 26 insertions(+), 23 deletions(-)