mbox series

[v5,0/6] blk-wbt: simple improvment to enable wbt correctly

Message ID 20221019121518.3865235-1-yukuai1@huaweicloud.com (mailing list archive)
Headers show
Series blk-wbt: simple improvment to enable wbt correctly | expand

Message

Yu Kuai Oct. 19, 2022, 12:15 p.m. UTC
From: Yu Kuai <yukuai3@huawei.com>

changes in v5:
 - code adjustment in patch 4, as suggested by Christoph.
 - add review tag by Christop.

changes in v4:
 - remove patch 3 from v3
 - add patch 2,3 in v4

changes in v3:
 - instead of check elevator name, add a flag in elevator_queue, as
 suggested by Christoph.
 - add patch 3 and patch 5 to this patchset.

changes in v2:
 - define new api if wbt config is not enabled in patch 1.

Yu Kuai (6):
  elevator: remove redundant code in elv_unregister_queue()
  blk-wbt: remove unnecessary check in wbt_enable_default()
  blk-wbt: make enable_state more accurate
  blk-wbt: don't show valid wbt_lat_usec in sysfs while wbt is disabled
  elevator: add new field flags in struct elevator_queue
  blk-wbt: don't enable throttling if default elevator is bfq

 block/bfq-iosched.c |  2 ++
 block/blk-sysfs.c   |  3 +++
 block/blk-wbt.c     | 26 ++++++++++++++++++++++----
 block/blk-wbt.h     | 17 ++++++++++++-----
 block/elevator.c    |  8 ++------
 block/elevator.h    |  5 ++++-
 6 files changed, 45 insertions(+), 16 deletions(-)

Comments

Yu Kuai Oct. 23, 2022, 2:25 a.m. UTC | #1
Hi, Jens

Can you apply this patchset?

Thanks,
Kuai

在 2022/10/19 20:15, Yu Kuai 写道:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> changes in v5:
>   - code adjustment in patch 4, as suggested by Christoph.
>   - add review tag by Christop.
> 
> changes in v4:
>   - remove patch 3 from v3
>   - add patch 2,3 in v4
> 
> changes in v3:
>   - instead of check elevator name, add a flag in elevator_queue, as
>   suggested by Christoph.
>   - add patch 3 and patch 5 to this patchset.
> 
> changes in v2:
>   - define new api if wbt config is not enabled in patch 1.
> 
> Yu Kuai (6):
>    elevator: remove redundant code in elv_unregister_queue()
>    blk-wbt: remove unnecessary check in wbt_enable_default()
>    blk-wbt: make enable_state more accurate
>    blk-wbt: don't show valid wbt_lat_usec in sysfs while wbt is disabled
>    elevator: add new field flags in struct elevator_queue
>    blk-wbt: don't enable throttling if default elevator is bfq
> 
>   block/bfq-iosched.c |  2 ++
>   block/blk-sysfs.c   |  3 +++
>   block/blk-wbt.c     | 26 ++++++++++++++++++++++----
>   block/blk-wbt.h     | 17 ++++++++++++-----
>   block/elevator.c    |  8 ++------
>   block/elevator.h    |  5 ++++-
>   6 files changed, 45 insertions(+), 16 deletions(-)
>
Jens Axboe Oct. 23, 2022, 3:02 a.m. UTC | #2
On Wed, 19 Oct 2022 20:15:12 +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> changes in v5:
>  - code adjustment in patch 4, as suggested by Christoph.
>  - add review tag by Christop.
> 
> changes in v4:
>  - remove patch 3 from v3
>  - add patch 2,3 in v4
> 
> [...]

Applied, thanks!

[1/6] elevator: remove redundant code in elv_unregister_queue()
      commit: 4321c1ad4abe05fb3683745ed52d0ca17918d537
[2/6] blk-wbt: remove unnecessary check in wbt_enable_default()
      commit: e2c2a27a4fef0af09bfb50c017d1d1962aa8784b
[3/6] blk-wbt: make enable_state more accurate
      commit: 563ee8c7ebfa01d43fa9a785c562318b3f6a587b
[4/6] blk-wbt: don't show valid wbt_lat_usec in sysfs while wbt is disabled
      commit: a66d2566505c819261591fb2462a99069c43db55
[5/6] elevator: add new field flags in struct elevator_queue
      commit: dd58a3a032d5b53571e9934b23a4ceae7b158db0
[6/6] blk-wbt: don't enable throttling if default elevator is bfq
      commit: b192851f14d980f8ce794e747adc4a2418527a75

Best regards,