[v4,0/7]

Message

Damien Le Moal Oct. 31, 2022, 1:53 a.m. UTC

These patches cleanup and improve libata support for the FUA device
feature. Patch 6 enables FUA support by default for any drive that
reports supporting the feature as well as NCQ.

Changes from v3:
- Added patch 1 to prevent any block device user from issuing a
  REQ_FUA read.
- Changed patch 5 to remove the check for REQ_FUA read and also remove 
  support for ATA_CMD_WRITE_MULTI_FUA_EXT as this command is obsolete
  in recent ACS specifications.

Changes from v2:
 - Added patch 1 and 2 as preparatory patches
 - Added patch 4 to fix FUA writes handling for the non-ncq case. Note
   that it is possible that the drives blacklisted in patch 5 are
   actually OK since the code back in 2012 had the issue with the wrong
   use of LBA 28 commands for FUA writes.

Changes from v1:
 - Removed Maciej's patch 2. Instead, blacklist drives which are known
   to have a buggy FUA support.

Damien Le Moal (7):
  block: Prevent the use of REQ_FUA with read operations
  ata: libata: Introduce ata_ncq_supported()
  ata: libata: Rename and cleanup ata_rwcmd_protocol()
  ata: libata: cleanup fua support detection
  ata: libata: Fix FUA handling in ata_build_rw_tf()
  ata: libata: blacklist FUA support for known buggy drives
  ata: libata: Enable fua support by default

 .../admin-guide/kernel-parameters.txt         |  3 +
 block/blk-flush.c                             | 12 +++
 drivers/ata/libata-core.c                     | 77 ++++++++++++++-----
 drivers/ata/libata-scsi.c                     | 30 +-------
 include/linux/libata.h                        | 34 +++++---
 5 files changed, 100 insertions(+), 56 deletions(-)

Comments

Chaitanya Kulkarni Oct. 31, 2022, 1:59 a.m. UTC | #1

On 10/30/2022 6:53 PM, Damien Le Moal wrote:
> These patches cleanup and improve libata support for the FUA device
> feature. Patch 6 enables FUA support by default for any drive that
> reports supporting the feature as well as NCQ.
> 
>

subject line would be really useful to check the previous
discussions ...

-ck

Damien Le Moal Oct. 31, 2022, 2:19 a.m. UTC | #2

On 10/31/22 10:59, Chaitanya Kulkarni wrote:
> On 10/30/2022 6:53 PM, Damien Le Moal wrote:
>> These patches cleanup and improve libata support for the FUA device
>> feature. Patch 6 enables FUA support by default for any drive that
>> reports supporting the feature as well as NCQ.
>>
>>
> 
> subject line would be really useful to check the previous
> discussions ...

Arg. Sorry. It is: "Improve libata support for FUA".
Forgot to copy that when changing the cover letter from v3.

> 
> -ck
> 
> 
> 
>