[v4,0/8] A few bugfix and cleancode patch for bfq

Message

Kemeng Shi Jan. 16, 2023, 9:51 a.m. UTC

Hi, this series contain two patches to fix bug in request injection
mechanism and some random cleancode patches.
Thanks!

---
V4:
 -Thanks Jan and Damien for review. Collect Reviewed-by from Jan and
Damien. Now all patches get Reviewed-by tag.
 -Make patches based on latest code and fix conflicts of patch 1/8
"block, bfq: correctly raise inject limit in bfq_choose_bfqq_for_injection"
and 5/8 "block, bfq: remove unnecessary dereference to get async_bfqq"

---
V3:
 -Thanks Jan for review. Remove unnecessary brace in patch "block, bfq:
remove unnecessary goto tag in bfq_dispatch_rq_from_bfqq" according to
recommend from Jan and collect Reviewed-by tag from Jan for rest
patches.
 -Drop patch "block, bfq: remove redundant bfqd->rq_in_driver > 0 check
in bfq_add_request" and "block, bfq: remove check of
bfq_wr_max_softrt_rate which is always greater than 0".

---
v2:
 -improve git log.
---

Kemeng Shi (8):
  block, bfq: correctly raise inject limit in
    bfq_choose_bfqq_for_injection
  block, bfq: remove unsed parameter reason in bfq_bfqq_is_slow
  block, bfq: initialize bfqq->decrease_time_jif correctly
  block, bfq: use helper macro RQ_BFQQ to get bfqq of request
  block, bfq: remove unnecessary dereference to get async_bfqq
  block, bfq: remove redundant check in bfq_put_cooperator
  block, bfq: remove unnecessary goto tag in bfq_dispatch_rq_from_bfqq
  block, bfq: remove unused bfq_wr_max_time in struct bfq_data

 block/bfq-iosched.c | 40 +++++++++++++++-------------------------
 block/bfq-iosched.h |  2 --
 2 files changed, 15 insertions(+), 27 deletions(-)

Comments

Jens Axboe Jan. 30, 2023, 3:04 a.m. UTC | #1

On Mon, 16 Jan 2023 17:51:45 +0800, Kemeng Shi wrote:
> mechanism and some random cleancode patches.
> Thanks!
> 

Applied, thanks!

[1/8] block, bfq: correctly raise inject limit in bfq_choose_bfqq_for_injection
      commit: 0c3e09e8854bcd3f7c45de85007ed283342b3464
[2/8] block, bfq: remove unsed parameter reason in bfq_bfqq_is_slow
      commit: bebeb9e582e8040944b12942ccc56f4ebacaa9f8
[3/8] block, bfq: initialize bfqq->decrease_time_jif correctly
      commit: 1c970450a7fd8be0298758c4e2c631e4a739292d
[4/8] block, bfq: use helper macro RQ_BFQQ to get bfqq of request
      commit: 8ac2e43c3559f29513377df8aff7a22a8277fcf8
[5/8] block, bfq: remove unnecessary dereference to get async_bfqq
      commit: 86f8382e6d3a74f783c23a3d773285e2637b8bc2
[6/8] block, bfq: remove redundant check in bfq_put_cooperator
      commit: 433d4b03e722bdfb1b6a75563cb45e8dca6784e7
[7/8] block, bfq: remove unnecessary goto tag in bfq_dispatch_rq_from_bfqq
      commit: 87c971de8157b90494490d7c869a21b7f2123305
[8/8] block, bfq: remove unused bfq_wr_max_time in struct bfq_data
      commit: 323745a3aa9ba172582d4549689146298fb68405

Best regards,